Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support primitive types as source of Pure mappings #3788

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Conversation

aziemchawdhary-gs
Copy link
Contributor

Update Pure mapping metamodel to handle primitive types as source of Pure mappings (mirrors change to engine: finos/legend-engine#3246)

@aziemchawdhary-gs aziemchawdhary-gs requested a review from a team as a code owner January 6, 2025 21:50
Copy link

changeset-bot bot commented Jan 6, 2025

🦋 Changeset detected

Latest commit: b67fb73

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
@finos/legend-application-studio Patch
@finos/legend-graph Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-data-quality Patch
@finos/legend-extension-dsl-data-space-studio Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-vscode-extension-dependencies Patch
@finos/legend-application-data-cube Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-query Patch
@finos/legend-application-repl Patch
@finos/legend-code-editor Patch
@finos/legend-data-cube Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-lego Patch
@finos/legend-query-builder Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-data-cube-bootstrap Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-repl-deployment Patch
@finos/legend-application-data-cube-deployment Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aziemchawdhary-gs aziemchawdhary-gs marked this pull request as draft January 6, 2025 21:50
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 45.22%. Comparing base (fe9b778) to head (b67fb73).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
...or/editor-group/data-editor/EmbeddedDataEditor.tsx 33.33% 2 Missing ⚠️
...on-studio/src/stores/editor/utils/TestableUtils.ts 33.33% 2 Missing ⚠️
...tor-state/mapping/testable/MappingTestingHelper.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3788      +/-   ##
==========================================
+ Coverage   44.48%   45.22%   +0.74%     
==========================================
  Files        2245     2245              
  Lines      389572   390292     +720     
  Branches    16380    16508     +128     
==========================================
+ Hits       173306   176516    +3210     
+ Misses     215798   212749    -3049     
- Partials      468     1027     +559     
Files with missing lines Coverage Δ
...res/graph-modifier/DSL_Data_GraphModifierHelper.ts 65.97% <100.00%> (+0.23%) ⬆️
...on/pureGraph/to/V1_ClassMappingFirstPassBuilder.ts 72.05% <100.00%> (ø)
...raph/src/graph/metamodel/pure/data/EmbeddedData.ts 86.99% <100.00%> (ø)
...elToModel/mapping/PureInstanceSetImplementation.ts 98.70% <100.00%> (+0.01%) ⬆️
...tor-state/mapping/testable/MappingTestingHelper.ts 60.70% <50.00%> (+0.13%) ⬆️
...or/editor-group/data-editor/EmbeddedDataEditor.tsx 25.56% <33.33%> (ø)
...on-studio/src/stores/editor/utils/TestableUtils.ts 61.90% <33.33%> (ø)

... and 455 files with indirect coverage changes

@aziemchawdhary-gs aziemchawdhary-gs marked this pull request as ready for review January 7, 2025 08:21
@akphi akphi merged commit 0cb9701 into master Jan 7, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants