Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datacube: bug fixes and improve roundtrip #3806

Merged
merged 14 commits into from
Jan 14, 2025
Merged

Conversation

akphi
Copy link
Contributor

@akphi akphi commented Jan 13, 2025

  • bump dependencies
   @babel/eslint-parser ------------------------ ◯ 7.25.9 ------- ◉ 7.26.5 -------
   @babel/helper-plugin-utils ------------------ ◯ 7.25.9 ------- ◉ 7.26.5 -------
   @eslint/js ---------------------------------- ◯ 9.17.0 ------- ◉ 9.18.0 -------
   @types/node --------------------------------- ◯ 22.10.5 ------ ◉ 22.10.6 ------
   @types/react-dom ---------------------------- ◯ 19.0.2 ------- ◉ 19.0.3 -------
   @types/react -------------------------------- ◯ 19.0.4 ------- ◉ 19.0.7 -------
   @typescript-eslint/eslint-plugin ------------ ◯ 8.19.1 ------- ◉ 8.20.0 -------
   @typescript-eslint/parser ------------------- ◯ 8.19.1 ------- ◉ 8.20.0 -------
   eslint-config-prettier ---------------------- ◯ 9.1.0 --------                  ◉ 10.0.1 -------
   eslint-plugin-react ------------------------- ◯ 7.37.3 ------- ◉ 7.37.4 -------
   eslint -------------------------------------- ◯ 9.17.0 ------- ◉ 9.18.0 -------
   inquirer ------------------------------------ ◯ 12.3.0 ------- ◉ 12.3.2 -------
   papaparse ----------------------------------- ◯ 5.5.0 -------- ◉ 5.5.1 --------
   postcss ------------------------------------- ◯ 8.4.49 ------- ◉ 8.5.1 --------
   sass ---------------------------------------- ◯ 1.83.1 ------- ◉ 1.83.4 -------
   sort-package-json --------------------------- ◯ 2.12.0 ------- ◉ 2.13.0 -------
   stylelint-config-standard ------------------- ◯ 36.0.1 -------                  ◉ 37.0.0 -------
   stylelint ----------------------------------- ◯ 16.12.0 ------ ◉ 16.13.2 ------
   uuid ---------------------------------------- ◯ 11.0.4 ------- ◉ 11.0.5 -------

Copy link

changeset-bot bot commented Jan 13, 2025

🦋 Changeset detected

Latest commit: e0c95f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 43 packages
Name Type
@finos/legend-application-data-cube-deployment Patch
@finos/legend-application-repl-deployment Patch
@finos/legend-application-data-cube Patch
@finos/legend-application-repl Patch
@finos/legend-data-cube Patch
@finos/legend-shared Major
@finos/legend-graph Patch
@finos/legend-extension-dsl-data-space-studio Patch
@finos/legend-extension-dsl-data-quality Patch
@finos/legend-server-showcase-deployment Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-studio Patch
@finos/legend-application-query Patch
@finos/legend-query-builder Patch
@finos/legend-code-editor Patch
@finos/legend-application-data-cube-bootstrap Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-vscode-extension-dependencies Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-tracer-zipkin Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-server-showcase Patch
@finos/legend-server-depot Patch
@finos/legend-application Patch
@finos/legend-server-sdlc Patch
@finos/legend-dev-utils Patch
@finos/stylelint-config-legend-studio Patch
@finos/legend-storage Patch
@finos/eslint-plugin-legend-studio Patch
@finos/babel-preset-legend-studio Patch
@finos/legend-lego Patch
@finos/legend-art Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 71.70805% with 376 lines in your changes missing coverage. Please review.

Project coverage is 45.49%. Comparing base (5a1d511) to head (e0c95f5).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...c/stores/core/DataCubeQuerySnapshotBuilderUtils.ts 83.27% 51 Missing ⚠️
...-cube/src/stores/core/DataCubeQueryBuilderUtils.ts 26.31% 28 Missing ⚠️
...be/src/stores/core/DataCubeQuerySnapshotBuilder.ts 84.80% 19 Missing ⚠️
...mponents/states/DataQualityClassValidationState.ts 0.00% 15 Missing ⚠️
.../graph-manager/__test-utils__/EngineTestSupport.ts 0.00% 15 Missing ⚠️
...e/src/stores/view/grid/DataCubeGridMenuBuilder.tsx 0.00% 14 Missing ⚠️
...rc/components/view/filter/DataCubeFilterEditor.tsx 0.00% 10 Missing ⚠️
...-data-cube/src/stores/core/DataCubeQueryBuilder.ts 50.00% 10 Missing ⚠️
...e/src/stores/view/grid/DataCubeGridQueryBuilder.ts 0.00% 9 Missing ⚠️
...components/DataQualityMappingAndRuntimeBuilder.tsx 0.00% 9 Missing ⚠️
... and 78 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3806      +/-   ##
==========================================
+ Coverage   45.32%   45.49%   +0.16%     
==========================================
  Files        2245     2245              
  Lines      390507   390319     -188     
  Branches    10849    16151    +5302     
==========================================
+ Hits       177013   177560     +547     
+ Misses     213028   212294     -734     
+ Partials      466      465       -1     
Files with missing lines Coverage Δ
...-query/src/stores/LegendQueryApplicationPlugin.tsx 100.00% <ø> (ø)
...t-editor-state/service/ServiceRegistrationState.ts 90.16% <100.00%> (-0.03%) ⬇️
...tor-state/service/testable/ServiceTestableState.ts 68.64% <100.00%> (-0.26%) ⬇️
...on-studio/src/stores/editor/utils/TestableUtils.ts 61.67% <100.00%> (-0.23%) ⬇️
...d-data-cube/src/components/DataCubePlaceholder.tsx 0.00% <ø> (ø)
...d-data-cube/src/stores/core/DataCubeQueryEngine.ts 96.06% <100.00%> (+5.77%) ⬆️
...data-cube/src/stores/core/DataCubeQuerySnapshot.ts 83.42% <100.00%> (ø)
...stores/core/filter/DataCubeQueryFilterOperation.ts 72.41% <100.00%> (+8.58%) ⬆️
...eryFilterOperation__EqualCaseInsensitiveColumn.tsx 88.77% <100.00%> (+33.40%) ⬆️
...lter/DataCubeQueryFilterOperation__EqualColumn.tsx 88.42% <100.00%> (+21.44%) ⬆️
... and 105 more

... and 48 files with indirect coverage changes

@akphi akphi marked this pull request as ready for review January 14, 2025 19:00
@akphi akphi requested a review from a team as a code owner January 14, 2025 19:00
@MauricioUyaguari MauricioUyaguari merged commit e6d29c3 into finos:master Jan 14, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants