Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support open datacube query with parameters #3810

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

YannanGao-gs
Copy link
Contributor

@YannanGao-gs YannanGao-gs commented Jan 14, 2025

Summary

before:

Screen.Recording.2025-01-15.at.10.05.40.AM.mov

after:

Screen.Recording.2025-01-15.at.3.31.38.PM.mov

support open datacube query with parameters

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@YannanGao-gs YannanGao-gs requested a review from a team as a code owner January 14, 2025 20:31
Copy link

changeset-bot bot commented Jan 14, 2025

🦋 Changeset detected

Latest commit: a14cb79

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
@finos/legend-application-data-cube Patch
@finos/legend-data-cube Patch
@finos/legend-graph Patch
@finos/legend-application-data-cube-bootstrap Patch
@finos/legend-application-query Patch
@finos/legend-application-repl Patch
@finos/legend-application-studio Patch
@finos/legend-query-builder Patch
@finos/legend-vscode-extension-dependencies Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-code-editor Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-data-quality Patch
@finos/legend-extension-dsl-data-space-studio Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-lego Patch
@finos/legend-application-data-cube-deployment Patch
@finos/legend-application-repl-deployment Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@YannanGao-gs YannanGao-gs marked this pull request as draft January 14, 2025 20:31
@YannanGao-gs YannanGao-gs force-pushed the cubeParameter branch 2 times, most recently from 856077e to 8d71b7f Compare January 15, 2025 14:52
@YannanGao-gs YannanGao-gs changed the title [WIP]support open datacube query with parameters support open datacube query with parameters Jan 15, 2025
@YannanGao-gs YannanGao-gs self-assigned this Jan 15, 2025
@YannanGao-gs YannanGao-gs marked this pull request as ready for review January 15, 2025 15:18
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 7.79221% with 71 lines in your changes missing coverage. Please review.

Project coverage is 45.44%. Comparing base (ef8703e) to head (a14cb79).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
...ta-cube/src/stores/LegendDataCubeDataCubeEngine.ts 0.00% 31 Missing ⚠️
...ers/V1_RawValueSpecificationSerializationHelper.ts 13.33% 26 Missing ⚠️
...cube/src/stores/model/LegendQueryDataCubeSource.ts 0.00% 6 Missing ⚠️
...ph-manager/protocol/pure/v1/V1_PureGraphManager.ts 14.28% 6 Missing ⚠️
packages/legend-data-cube/src/index.tsx 0.00% 1 Missing ⚠️
packages/legend-graph/src/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3810      +/-   ##
==========================================
- Coverage   45.49%   45.44%   -0.05%     
==========================================
  Files        2245     2245              
  Lines      390321   390389      +68     
  Branches    16738    16083     -655     
==========================================
- Hits       177562   177428     -134     
- Misses     211732   212174     +442     
+ Partials     1027      787     -240     
Files with missing lines Coverage Δ
...gend-graph/src/graph-manager/action/query/Query.ts 42.01% <100.00%> (+0.34%) ⬆️
packages/legend-data-cube/src/index.tsx 0.00% <0.00%> (ø)
packages/legend-graph/src/index.ts 0.00% <0.00%> (ø)
...cube/src/stores/model/LegendQueryDataCubeSource.ts 0.00% <0.00%> (ø)
...ph-manager/protocol/pure/v1/V1_PureGraphManager.ts 48.35% <14.28%> (-0.06%) ⬇️
...ers/V1_RawValueSpecificationSerializationHelper.ts 71.73% <13.33%> (-5.26%) ⬇️
...ta-cube/src/stores/LegendDataCubeDataCubeEngine.ts 0.00% <0.00%> (ø)

... and 264 files with indirect coverage changes

@MauricioUyaguari MauricioUyaguari merged commit 651cd64 into finos:master Jan 21, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants