Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Runtime Components to Execution Environment #3821

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

YannanGao-gs
Copy link
Contributor

@YannanGao-gs YannanGao-gs commented Jan 20, 2025

Summary

related to finos/legend-engine#3223

Screen.Recording.2025-01-20.at.11.24.02.AM.mov

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@YannanGao-gs YannanGao-gs requested a review from a team as a code owner January 20, 2025 16:24
Copy link

changeset-bot bot commented Jan 20, 2025

🦋 Changeset detected

Latest commit: 82ae647

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
@finos/legend-graph Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-application-data-cube Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-query Patch
@finos/legend-application-repl Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-application-studio Patch
@finos/legend-code-editor Patch
@finos/legend-data-cube Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-data-quality Patch
@finos/legend-extension-dsl-data-space-studio Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-lego Patch
@finos/legend-query-builder Patch
@finos/legend-vscode-extension-dependencies Patch
@finos/legend-application-data-cube-bootstrap Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-repl-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-data-cube-deployment Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 35.34483% with 75 lines in your changes missing coverage. Please review.

Project coverage is 45.43%. Comparing base (c4db3c1) to head (82ae647).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...reGraph/to/V1_ExecutionEnvironmentBuilderHelper.ts 12.50% 21 Missing ⚠️
...reGraph/from/V1_ExecutionEnvironmentTransformer.ts 13.63% 19 Missing ⚠️
...lements/service/V1_ExecutionEnvironmentInstance.ts 19.04% 17 Missing ⚠️
...leElements/service/ExecutionEnvironmentInstance.ts 19.04% 17 Missing ⚠️
...changeDetection/STO_ServiceStore_ObserverHelper.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3821      +/-   ##
==========================================
- Coverage   45.53%   45.43%   -0.11%     
==========================================
  Files        2245     2245              
  Lines      390320   390428     +108     
  Branches    16778    16692      -86     
==========================================
- Hits       177751   177388     -363     
- Misses     211595   212013     +418     
- Partials      974     1027      +53     
Files with missing lines Coverage Δ
...pers/V1_ExecutionEnvironmentSerializationHelper.ts 84.35% <100.00%> (+3.20%) ⬆️
packages/legend-graph/src/graph/Core_HashUtils.ts 100.00% <100.00%> (ø)
...changeDetection/STO_ServiceStore_ObserverHelper.ts 35.12% <0.00%> (-0.08%) ⬇️
...lements/service/V1_ExecutionEnvironmentInstance.ts 42.00% <19.04%> (-5.57%) ⬇️
...leElements/service/ExecutionEnvironmentInstance.ts 42.26% <19.04%> (-5.17%) ⬇️
...reGraph/from/V1_ExecutionEnvironmentTransformer.ts 44.08% <13.63%> (-8.70%) ⬇️
...reGraph/to/V1_ExecutionEnvironmentBuilderHelper.ts 45.04% <12.50%> (-8.37%) ⬇️

... and 65 files with indirect coverage changes

@MauricioUyaguari MauricioUyaguari merged commit da839ba into finos:master Jan 21, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants