Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add composite index testing guidance to ReadMe #5421

Merged
merged 33 commits into from
Oct 20, 2023
Merged

Add composite index testing guidance to ReadMe #5421

merged 33 commits into from
Oct 20, 2023

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Oct 13, 2023 •
edited
Loading

Add guidance to ReadMe File
Add message for terraform workflow to ignore "index already exists" error message.

@milaGGL milaGGL self-assigned this Oct 13, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023 •
edited
Loading

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023 •
edited
Loading

Unit Test Results

     936 files  +     73       936 suites  +73   41m 32s ⏱️ + 4m 8s
  5 097 tests +       5    5 076 ✔️ +       7  21 💤 ±0  0 ❌  - 2 
10 279 runs  +1 117  10 237 ✔️ +1 119  42 💤 ±0  0 ❌  - 2 

Results for commit facefcb. ± Comparison against base commit 1073ded.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 13, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (1073ded) and merge commit (87a95ce).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/uaF4UctvF3.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 13, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from ? (1073ded) to 75.99% (87a95ce) by ?.

    68 individual files with coverage change

    FilenameBase (1073ded)Merge (87a95ce)Diff
    AabUpdater.java?98.36%?
    AabUpdater_Factory.java?0.00%?
    ApkInstaller.java?100.00%?
    ApkInstaller_Factory.java?0.00%?
    ApkUpdater.java?92.63%?
    ApkUpdater_Factory.java?0.00%?
    AppDistributionReleaseImpl.java?100.00%?
    AppDistributionReleaseInternal.java?100.00%?
    AppDistroComponent.java?0.00%?
    AppDistroComponent_MainModule_BindContentResolverFactory.java?0.00%?
    AppIconSource.java?84.62%?
    AppIconSource_Factory.java?100.00%?
    AutoValue_AppDistributionReleaseImpl.java?65.45%?
    AutoValue_AppDistributionReleaseInternal.java?71.58%?
    AutoValue_ImageUtils_ImageSize.java?35.00%?
    AutoValue_TesterApiDisabledErrorDetails.java?29.41%?
    AutoValue_TesterApiDisabledErrorDetails_HelpLink.java?54.17%?
    AutoValue_UpdateProgressImpl.java?65.96%?
    DaggerAppDistroComponent.java?80.56%?
    DevModeDetector.java?9.09%?
    DevModeDetector_Factory.java?100.00%?
    ErrorMessages.java?0.00%?
    FeedbackActivity.java?3.39%?
    FeedbackActivity_MembersInjector.java?0.00%?
    FeedbackSender.java?84.48%?
    FeedbackSender_Factory.java?0.00%?
    FeedbackTrigger.java?61.54%?
    FirebaseAppDistributionExceptions.java?80.00%?
    FirebaseAppDistributionFileProvider.java?0.00%?
    FirebaseAppDistributionImpl.java?89.89%?
    FirebaseAppDistributionImpl_Factory.java?0.00%?
    FirebaseAppDistributionLifecycleNotifier.java?91.49%?
    FirebaseAppDistributionLifecycleNotifier_Factory.java?0.00%?
    FirebaseAppDistributionNotificationsManager.java?88.89%?
    FirebaseAppDistributionNotificationsManager_Factory.java?0.00%?
    FirebaseAppDistributionRegistrar.java?95.83%?
    FirebaseAppDistributionTesterApiClient.java?88.78%?
    FirebaseAppDistributionTesterApiClient_Factory.java?0.00%?
    HttpsUrlConnectionFactory.java?50.00%?
    HttpsUrlConnectionFactory_Factory.java?100.00%?
    ImageUtils.java?100.00%?
    InstallActivity.java?2.67%?
    LogWrapper.java?86.67%?
    NewReleaseFetcher.java?86.67%?
    NewReleaseFetcher_Factory.java?0.00%?
    PackageInfoUtils.java?42.86%?
    ReleaseIdentifier.java?91.78%?
    ReleaseIdentifier_Factory.java?0.00%?
    ReleaseUtils.java?83.33%?
    ScreenshotTaker.java?36.17%?
    ScreenshotTaker_Factory.java?0.00%?
    SequentialReference.java?100.00%?
    SignInResultActivity.java?0.00%?
    SignInStorage.java?100.00%?
    SignInStorage_Factory.java?0.00%?
    TakeScreenshotAndStartFeedbackActivity.java?0.00%?
    TakeScreenshotAndStartFeedbackActivity_MembersInjector.java?0.00%?
    TaskCache.java?100.00%?
    TaskCompletionSourceCache.java?72.41%?
    TaskUtils.java?77.50%?
    TesterApiDisabledErrorDetails.java?93.75%?
    TesterApiHttpClient.java?90.09%?
    TesterApiHttpClient_Factory.java?0.00%?
    TesterSignInManager.java?95.45%?
    TesterSignInManager_Factory.java?0.00%?
    UpdateProgressImpl.java?100.00%?
    UpdateTaskCache.java?91.30%?
    UpdateTaskImpl.java?76.32%?

  • firebase-database

    Overall coverage changed from 50.13% (1073ded) to 50.14% (87a95ce) by +0.01%.

    FilenameBase (1073ded)Merge (87a95ce)Diff
    ChildChangeAccumulator.java96.67%83.33%-13.33%
    QueryParams.java89.76%90.36%+0.60%
    WebsocketConnection.java32.77%35.03%+2.26%

  • firebase-firestore

    Overall coverage changed from 44.75% (1073ded) to 44.76% (87a95ce) by +0.02%.

    FilenameBase (1073ded)Merge (87a95ce)Diff
    DeleteMutation.java90.48%95.24%+4.76%
    LruGarbageCollector.java93.64%97.27%+3.64%
    SetMutation.java97.22%94.44%-2.78%

  • firebase-messaging

    Overall coverage changed from 83.95% (1073ded) to 84.06% (87a95ce) by +0.11%.

    FilenameBase (1073ded)Merge (87a95ce)Diff
    Metadata.java36.51%41.27%+4.76%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/SJJr2F9a6M.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 13, 2023 •
edited
Loading

Startup Time Report 1

The report is too large (122,639 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/VBC5tIV4Sa/index.html

@milaGGL milaGGL requested a review from ehsannas October 16, 2023 17:04
@milaGGL milaGGL requested a review from ehsannas October 17, 2023 21:40
@milaGGL milaGGL assigned ehsannas and unassigned milaGGL Oct 18, 2023
@ehsannas ehsannas assigned milaGGL and unassigned ehsannas Oct 20, 2023
@milaGGL milaGGL merged commit 1c45fd5 into master Oct 20, 2023
161 checks passed
@milaGGL milaGGL deleted the mila/add-composite-index-testing-guide branch October 20, 2023 18:53
@firebase firebase locked and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ehsannas ehsannas ehsannas approved these changes

Assignees

@milaGGL milaGGL

Labels
no-changelog size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@milaGGL @google-oss-bot @ehsannas