Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Added test_mtx_fmt function #34

Merged
merged 2 commits into from
Aug 15, 2018
Merged

[ENH] Added test_mtx_fmt function #34

merged 2 commits into from
Aug 15, 2018

Conversation

akimbler
Copy link
Member

@akimbler akimbler commented Aug 15, 2018

Works on #1.

Changes proposed in this pull request:

  • Add function to test the directionality and binary/weighted status of an input connectivity matrix.

Added function for testing the directionality and binary/weighted status of an input connectivity matrix
@tsalo tsalo changed the title Added test_mtx_fmt function [ENH] Added test_mtx_fmt function Aug 15, 2018
@codecov-io
Copy link

codecov-io commented Aug 15, 2018

Codecov Report

Merging #34 into master will decrease coverage by 0.13%.
The diff coverage is 8.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #34      +/-   ##
=========================================
- Coverage   41.64%   41.5%   -0.14%     
=========================================
  Files          41      41              
  Lines        4990    5002      +12     
=========================================
- Hits         2078    2076       -2     
- Misses       2912    2926      +14
Impacted Files Coverage Δ
brainconn/utils/matrix.py 61.33% <8.33%> (-10.1%) ⬇️
brainconn/tests/test_modularity.py 89.83% <0%> (-2.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 188c94b...2d6b113. Read the comment docs.

Copy link
Member Author

@akimbler akimbler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed Two formatting errors and naming

@tsalo
Copy link
Member

tsalo commented Aug 15, 2018

Everything looks good to me. Merging now.

@tsalo tsalo merged commit 16a9830 into fiuneuro:master Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants