Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust paragraph selector for Fox News parser #368

Merged
merged 3 commits into from
Feb 24, 2024
Merged

Adjust paragraph selector for Fox News parser #368

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9320b3f
adjust Fox News parser
MaxDall Feb 22, 2024
8d402a2
further enhance selector and add summary selector
MaxDall Feb 23, 2024
6607f08
loosen paywall constraint
MaxDall Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/fundus/publishers/us/fox_news.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
from typing import List, Optional

from lxml.cssselect import CSSSelector
from lxml.etree import XPath

from fundus.parser import ArticleBody, BaseParser, ParserProxy, attribute
from fundus.parser.utility import (
Expand All @@ -14,7 +15,11 @@

class FoxNewsParser(ParserProxy):
class V1(BaseParser):
_paragraph_selector = CSSSelector(".article-body > p")
_summary_selector = CSSSelector(".article-meta > h2")
_paragraph_selector = XPath(
"(//div[@class='article-body'] | //div[@class='article-body']/div[contains(@class, 'paywall')]) "
"/p[not(child::script) and text()]"
MaxDall marked this conversation as resolved.
Show resolved Hide resolved
)

@attribute
def body(self) -> ArticleBody:
MaxDall marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
Loading