Fix malformed HTML for TheNation
#385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 tasks
addie9800
requested changes
Mar 8, 2024
| @@ -63,8 +83,13 @@ def topics(self) -> List[str]: | |||
| class V2(V1): | |||
There was a problem hiding this comment.
It seems they (mostly) updated the way they assign topics. It seems to me that they stopped using the keywords tag, and switched to sailthru.tags. For this article for example, no topics were parsed: https://www.thenation.com/article/archive/gop-threatens-pepfar-hiv-aids-africa/
There was a problem hiding this comment.
Thanks for catching this 👍 i altered topic extraction for V2 accordingly
addie9800
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes parsing for the nation once again 🎉