Skip to content

Improve support for FQ qdisc stats and options available in newer kernel versions #484

Improve support for FQ qdisc stats and options available in newer kernel versions

Improve support for FQ qdisc stats and options available in newer kernel versions #484

Triggered via pull request April 12, 2024 05:09
Status Success
Total duration 1m 51s
Artifacts

go.yml

on: pull_request
Matrix: code-check
Matrix: go-test
Fit to window
Zoom out
Zoom in

Annotations

20 errors
code-check (1.20.x): ematch.go#L97
exported const EmatchRelEnd should have comment (or a comment on this block) or be unexported
code-check (1.20.x): ematch_nbyte.go#L7
exported type NByteMatch should have comment or be unexported
code-check (1.20.x): f_tcindex.go#L21
type name will be used as tc.TcIndex by other packages, and that stutters; consider calling this Index
code-check (1.20.x): q_cbs.go#L14
exported type CbsOpt should have comment or be unexported
code-check (1.20.x): q_fq.go#L32
exported type FqPrioQopt should have comment or be unexported
code-check (1.20.x): q_taprio.go#L25
exported type TaPrio should have comment or be unexported
code-check (1.20.x): ratetable_linux_test.go#L14
don't use underscores in Go names; var rate_1kbit_burst_40_mtu_9k should be rate1kbitBurst40Mtu9k
code-check (1.20.x): ratetable_linux_test.go#L59
don't use underscores in Go names; var rate_1mbit_burst_100k should be rate1mbitBurst100k
code-check (1.20.x): ratetable_linux_test.go#L104
don't use underscores in Go names; var rate_8kbit_burst_5kb_peakrate_12kbit_mpu_64_mtu_1464_drop should be rate8kbitBurst5kbPeakrate12kbitMpu64Mtu1464Drop
code-check (1.20.x): structs.go#L275
struct field TcpRetrans should be TCPRetrans
code-check (1.21.x): ematch.go#L97
exported const EmatchRelEnd should have comment (or a comment on this block) or be unexported
code-check (1.21.x): ematch_nbyte.go#L7
exported type NByteMatch should have comment or be unexported
code-check (1.21.x): f_tcindex.go#L21
type name will be used as tc.TcIndex by other packages, and that stutters; consider calling this Index
code-check (1.21.x): q_cbs.go#L14
exported type CbsOpt should have comment or be unexported
code-check (1.21.x): q_fq.go#L32
exported type FqPrioQopt should have comment or be unexported
code-check (1.21.x): q_taprio.go#L25
exported type TaPrio should have comment or be unexported
code-check (1.21.x): ratetable_linux_test.go#L14
don't use underscores in Go names; var rate_1kbit_burst_40_mtu_9k should be rate1kbitBurst40Mtu9k
code-check (1.21.x): ratetable_linux_test.go#L59
don't use underscores in Go names; var rate_1mbit_burst_100k should be rate1mbitBurst100k
code-check (1.21.x): ratetable_linux_test.go#L104
don't use underscores in Go names; var rate_8kbit_burst_5kb_peakrate_12kbit_mpu_64_mtu_1464_drop should be rate8kbitBurst5kbPeakrate12kbitMpu64Mtu1464Drop
code-check (1.21.x): structs.go#L275
struct field TcpRetrans should be TCPRetrans