Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump phpunit/phpunit from 10.5.40 to 11.5.3 in /tools/phpunit #1377

Merged
merged 27 commits into from
Jan 17, 2025

Conversation

Bellangelo
Copy link
Contributor

Change Log

Added

Fixed

  • TestCases new syntax

Changed

  • Bump phpunit/phpunit from 10.5.40 to 11.5.3

Removed

Deprecated

Security


Description

Copy link
Contributor

github-actions bot commented Jan 15, 2025

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak        | mode             | rstdev          |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.759mb +0.01%  | 547.620ms -0.85% | ±0.85% -50.54%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.827mb +0.01%  | 1.058s +1.41%    | ±0.36% -40.73%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 86.480mb +0.00% | 915.979ms +2.29% | ±0.39% +1.48%   |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.492mb +0.01%  | 33.830ms +0.13%  | ±0.80% -27.32%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.469mb +0.01%  | 601.080ms +0.07% | ±0.54% +199.33% |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev          |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 108.487mb +0.00% | 59.169ms -0.34% | ±0.88% +148.50% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
Loaders
+--------------------+----------------+------+-----+------------------+-----------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode            | rstdev          |
+--------------------+----------------+------+-----+------------------+-----------------+-----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.035mb +0.00%  | 97.668ms -2.66% | ±2.77% +167.32% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 76.795mb +0.00%  | 92.632ms +0.75% | ±0.26% -50.59%  |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 166.978mb +0.00% | 20.505s -0.34%  | ±0.15% -37.79%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.079mb +0.00%  | 30.123ms +1.26% | ±1.10% -35.56%  |
+--------------------+----------------+------+-----+------------------+-----------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev           |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 80.252mb +0.00%  | 3.351ms +6.07%   | ±3.85% +1305.66% |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 97.530mb +0.00%  | 187.319ms +1.11% | ±0.17% -64.98%   |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 80.250mb +0.00%  | 18.865ms +0.12%  | ±0.73% -47.19%   |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 81.127mb +0.00%  | 1.522ms +3.83%   | ±1.37% +3.26%    |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 81.127mb +0.00%  | 1.510ms -0.21%   | ±0.55% -78.92%   |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 79.288mb +0.00%  | 3.573ms +0.32%   | ±1.72% -1.05%    |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 79.817mb +0.00%  | 14.924ms +0.39%  | ±0.38% -39.21%   |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 79.817mb +0.00%  | 14.698ms -1.34%  | ±0.61% +2.09%    |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 78.508mb +0.00%  | 1.806μs +0.68%   | ±2.57% -3.64%    |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 78.508mb +0.00%  | 0.400μs 0.00%    | ±0.00% 0.00%     |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 86.845mb +0.00%  | 12.534ms -1.11%  | ±0.25% -40.72%   |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 114.193mb +0.00% | 57.139ms -3.44%  | ±1.76% +202.40%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 80.336mb +0.00%  | 1.338ms -0.30%   | ±0.73% -65.52%   |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 83.629mb +0.00%  | 61.504ms +2.01%  | ±0.57% +285.63%  |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 81.389mb +0.00%  | 3.702ms +0.74%   | ±1.74% +324.33%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 78.792mb +0.00%  | 42.406ms +2.93%  | ±0.58% +34.18%   |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 78.792mb +0.00%  | 42.652ms +2.31%  | ±2.26% +139.52%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 78.792mb +0.00%  | 42.713ms +3.34%  | ±0.75% -17.81%   |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 80.948mb +0.00%  | 8.158ms +1.86%   | ±1.77% +858.58%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 78.698mb +0.00%  | 29.245ms -0.37%  | ±0.34% -37.39%   |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 78.508mb +0.00%  | 14.288μs +4.29%  | ±0.66% +11.14%   |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 78.508mb +0.00%  | 15.300μs -6.58%  | ±0.53% -84.23%   |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 97.531mb +0.00%  | 192.428ms +1.33% | ±0.23% -75.51%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 98.643mb +0.00%  | 443.964ms +0.86% | ±0.13% -74.71%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 51.474mb +0.00%  | 219.739ms -0.10% | ±0.62% -13.01%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 13.646mb +0.00%  | 49.682ms +3.50%  | ±1.67% +283.74%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 43.777mb +0.00%  | 363.342ms +1.21% | ±0.70% -23.37%   |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 11.587mb +0.00%  | 72.191ms -0.88%  | ±1.34% +127.54%  |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+

@Bellangelo
Copy link
Contributor Author

Infection was failing because the CacheResultFile option in PHPUnit11 has been removed. See sebastianbergmann/phpunit#4600

I run also phpunit --migrate-configuration and except from the CacheResultFile we had no other change.

@Bellangelo
Copy link
Contributor Author

I don't understand why I am having this error

PHP Fatal error: Uncaught Error: Class "PHPUnit\Event\Code\NoTestCaseObjectOnCallStackException" not found in /home/runner/work/flow/flow/tools/phpunit/vendor/phpunit/phpunit/src/Event/Value/Test/TestMethodBuilder.php:62

I thought at first that it was a cache issue but I should have disabled it with my latest commits. I will check it later on.

Bellangelo and others added 15 commits January 17, 2025 01:12
…flow-php#1376)

Bumps [symfonycasts/tailwind-bundle](https://github.com/SymfonyCasts/tailwind-bundle) from 0.5.3 to 0.6.1.
- [Release notes](https://github.com/SymfonyCasts/tailwind-bundle/releases)
- [Commits](SymfonyCasts/tailwind-bundle@v0.5.3...v0.6.1)

---
updated-dependencies:
- dependency-name: symfonycasts/tailwind-bundle
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…p#1373)

Bumps [coduo/php-humanizer](https://github.com/coduo/php-humanizer) from 4.0.3 to 5.0.0.
- [Release notes](https://github.com/coduo/php-humanizer/releases)
- [Changelog](https://github.com/coduo/php-humanizer/blob/5.x/CHANGELOG.md)
- [Upgrade guide](https://github.com/coduo/php-humanizer/blob/5.x/UPGRADE.md)
- [Commits](coduo/php-humanizer@4.0.3...5.0.0)

---
updated-dependencies:
- dependency-name: coduo/php-humanizer
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [async-aws/s3](https://github.com/async-aws/s3) from 2.6.0 to 2.7.0.
- [Release notes](https://github.com/async-aws/s3/releases)
- [Changelog](https://github.com/async-aws/s3/blob/master/CHANGELOG.md)
- [Commits](async-aws/s3@2.6.0...2.7.0)

---
updated-dependencies:
- dependency-name: async-aws/s3
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Bellangelo
Copy link
Contributor Author

Main issues that were fixed:

  • Tests were failing because we weren't reverting the env variable after we were updating it. Fixed in 3c9a06d
  • A duplicated path throws a warning in PHPUnit11 and the Infection wasn't running because of it. Fixed in 3338108

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.51%. Comparing base (ee5f5fa) to head (3338108).
Report is 2 commits behind head on 1.x.

Additional details and impacted files
@@           Coverage Diff           @@
##              1.x    #1377   +/-   ##
=======================================
  Coverage   82.51%   82.51%           
=======================================
  Files         648      648           
  Lines       17395    17395           
=======================================
  Hits        14353    14353           
  Misses       3042     3042           
Components Coverage Δ
etl 85.82% <ø> (ø)
cli 85.17% <ø> (ø)
lib-array-dot 94.53% <ø> (ø)
lib-azure-sdk 62.56% <ø> (ø)
lib-doctrine-dbal-bulk 97.36% <ø> (ø)
lib-filesystem 76.23% <ø> (ø)
lib-parquet 84.57% <ø> (ø)
lib-parquet-viewer 82.02% <ø> (ø)
lib-rdsl 87.09% <ø> (ø)
lib-snappy 90.69% <ø> (ø)
bridge-filesystem-async-aws 90.38% <ø> (ø)
bridge-filesystem-azure 89.92% <ø> (ø)
bridge-monolog-http 96.38% <ø> (ø)
symfony-http-foundation 77.10% <ø> (ø)
adapter-chartjs 86.45% <ø> (ø)
adapter-csv 89.49% <ø> (ø)
adapter-doctrine 90.14% <ø> (ø)
adapter-elasticsearch 97.19% <ø> (ø)
adapter-google-sheet 78.04% <ø> (ø)
adapter-http 59.15% <ø> (ø)
adapter-json 92.85% <ø> (ø)
adapter-logger 53.84% <ø> (ø)
adapter-meilisearch 97.75% <ø> (ø)
adapter-parquet 59.88% <ø> (ø)
adapter-text 84.44% <ø> (ø)
adapter-xml 83.15% <ø> (ø)

@norberttech norberttech merged commit e0000ff into flow-php:1.x Jan 17, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants