Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bug when xml->deep > 1 and previousDeep > xml->deep #589

Closed
wants to merge 2 commits into from

Conversation

FunkyOz
Copy link
Contributor

@FunkyOz FunkyOz commented Oct 16, 2023

Change Log

Added

Fixed

  • Change behavior of xml adapter when xml->deep > 1 and previousDeep > xml->deep

Changed

Removed

Deprecated

Security


Description

The intent of thi PR is to fix a problem when an xml file is deeper than 2 tags.
I thinks it's better to decrement $previousDeep to $xml->deep as describe in this issue

@norberttech
Copy link
Member

Thanks @FunkyOz!!
Could you please resolve the conflict and look at the static analyze results? Locally you can execute whole test suite through composer build

@FunkyOz
Copy link
Contributor Author

FunkyOz commented Oct 16, 2023

Sure, I do it, thanks :)

@FunkyOz
Copy link
Contributor Author

FunkyOz commented Oct 16, 2023

@norberttech I'm an issue with composer build.
The command tools/phpstan/vendor/bin/phpstan analyze -c phpstan.neon --memory-limit=-1 fail with errors

 Line   adapter/etl-adapter-xml/src/Flow/ETL/Adapter/XML/XMLReaderExtractor.php               
 ------ -------------------------------------------------------------------------------------- 
  50     Access to an undefined property XMLReader::$nodeType.                                 
         💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property  
  51     Access to an undefined property XMLReader::$depth.                                    
         💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property  
  53     Access to an undefined property XMLReader::$name.                                     
         💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property  
  56     Access to an undefined property XMLReader::$depth.                                    
         💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property  
  57     Access to an undefined property XMLReader::$name.                                     
         💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property  
 ------ -------------------------------------------------------------------------------------- 


                                                                                                                        
 [ERROR] Found 5 errors                                                                                                 
                                                                                                                        

Script tools/phpstan/vendor/bin/phpstan analyze -c phpstan.neon --memory-limit=-1 handling the static:analyze event returned with error code 1
Script @static:analyze was called via build

But this properties are php built in. How do you resolve?

Also PR tell that there are conflics that I don't see.

Thk

@norberttech
Copy link
Member

Let me take care of this from here, #593 should contain your original commits + my rebase fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants