Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate baseline benchmark in one run not per group #673

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Conversation

stloyd
Copy link
Member

@stloyd stloyd commented Oct 30, 2023

Change Log

Added

Fixed

Changed

  • Generate baseline benchmark in one run not per group

Removed

Deprecated

Security


Description

There is an issue in phpbench saving different groups as different baseline files, but reading is always using the first file found ignoring all other files leading to missing difference notes.

There is issue in phpbench saving different groups as different baseline files, but reading is always using first file found ignoring all other files leading to missing difference notes.
@github-actions
Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+-----------+-----------+
| benchmark             | subject           | revs | its | mem_peak  | mode      |
+-----------------------+-------------------+------+-----+-----------+-----------+
| AvroExtractorBench    | bench_extract_10k | 5    | 3   | 44.122mb  | 497.185ms |
| CSVExtractorBench     | bench_extract_10k | 5    | 3   | 14.007mb  | 426.672ms |
| JsonExtractorBench    | bench_extract_10k | 5    | 3   | 18.669mb  | 849.034ms |
| ParquetExtractorBench | bench_extract_10k | 5    | 3   | 237.792mb | 1.133s    |
| TextExtractorBench    | bench_extract_10k | 5    | 3   | 7.277mb   | 16.144ms  |
| XmlExtractorBench     | bench_extract_10k | 5    | 3   | 7.624mb   | 712.992ms |
+-----------------------+-------------------+------+-----+-----------+-----------+
Transformers
+-----------------------------+--------------------------+------+-----+-----------------+-----------------+
| benchmark                   | subject                  | revs | its | mem_peak        | mode            |
+-----------------------------+--------------------------+------+-----+-----------------+-----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 5    | 5   | 87.062mb -0.00% | 69.632ms -0.19% |
+-----------------------------+--------------------------+------+-----+-----------------+-----------------+
Loaders
+--------------------+----------------+------+-----+-----------+-----------+
| benchmark          | subject        | revs | its | mem_peak  | mode      |
+--------------------+----------------+------+-----+-----------+-----------+
| AvroLoaderBench    | bench_load_10k | 5    | 3   | 219.956mb | 787.792ms |
| CSVLoaderBench     | bench_load_10k | 5    | 3   | 47.140mb  | 80.202ms  |
| JsonLoaderBench    | bench_load_10k | 5    | 3   | 88.580mb  | 82.449ms  |
| ParquetLoaderBench | bench_load_10k | 5    | 3   | 281.200mb | 1.129s    |
| TextLoaderBench    | bench_load_10k | 5    | 3   | 16.566mb  | 40.724ms  |
+--------------------+----------------+------+-----+-----------+-----------+
Building Blocks
+-------------------------+----------------------------+------+-----+----------+-----------+
| benchmark               | subject                    | revs | its | mem_peak | mode      |
+-------------------------+----------------------------+------+-----+----------+-----------+
| RowsBench               | bench_chunk_10_on_10k      | 5    | 5   | 60.694mb | 4.334ms   |
| RowsBench               | bench_diff_left_1k_on_10k  | 5    | 5   | 80.485mb | 196.417ms |
| RowsBench               | bench_diff_right_1k_on_10k | 5    | 5   | 59.011mb | 19.822ms  |
| RowsBench               | bench_drop_1k_on_10k       | 5    | 5   | 59.833mb | 3.182ms   |
| RowsBench               | bench_drop_right_1k_on_10k | 5    | 5   | 61.935mb | 3.237ms   |
| RowsBench               | bench_entries_on_10k       | 5    | 5   | 59.046mb | 4.109ms   |
| RowsBench               | bench_filter_on_10k        | 5    | 5   | 59.575mb | 26.120ms  |
| RowsBench               | bench_find_on_10k          | 5    | 5   | 59.575mb | 26.319ms  |
| RowsBench               | bench_find_one_on_10k      | 5    | 5   | 57.999mb | 25.474ms  |
| RowsBench               | bench_first_on_10k         | 5    | 5   | 57.646mb | 1.000μs   |
| RowsBench               | bench_flat_map_on_1k       | 5    | 5   | 65.880mb | 15.436ms  |
| RowsBench               | bench_map_on_10k           | 5    | 5   | 91.400mb | 70.338ms  |
| RowsBench               | bench_merge_1k_on_10k      | 5    | 5   | 60.096mb | 3.514ms   |
| RowsBench               | bench_partition_by_on_10k  | 5    | 5   | 64.467mb | 62.172ms  |
| RowsBench               | bench_remove_on_10k        | 5    | 5   | 62.196mb | 8.028ms   |
| RowsBench               | bench_sort_asc_on_1k       | 5    | 5   | 57.646mb | 58.960ms  |
| RowsBench               | bench_sort_by_on_1k        | 5    | 5   | 57.646mb | 58.831ms  |
| RowsBench               | bench_sort_desc_on_1k      | 5    | 5   | 57.646mb | 60.262ms  |
| RowsBench               | bench_sort_entries_on_1k   | 5    | 5   | 59.921mb | 10.734ms  |
| RowsBench               | bench_sort_on_1k           | 5    | 5   | 57.646mb | 44.494ms  |
| RowsBench               | bench_take_1k_on_10k       | 5    | 5   | 59.120mb | 140.618ms |
| RowsBench               | bench_take_right_1k_on_10k | 5    | 5   | 59.121mb | 1.097ms   |
| RowsBench               | bench_unique_on_1k         | 5    | 5   | 80.486mb | 202.318ms |
| NativeEntryFactoryBench | bench_10k_rows             | 5    | 5   | 83.906mb | 160.137ms |
| NativeEntryFactoryBench | bench_1k_rows              | 5    | 5   | 45.437mb | 16.077ms  |
| NativeEntryFactoryBench | bench_5k_rows              | 5    | 5   | 62.714mb | 80.321ms  |
+-------------------------+----------------------------+------+-----+----------+-----------+

@stloyd stloyd merged commit 9974cca into 1.x Oct 30, 2023
16 checks passed
@stloyd stloyd deleted the stloyd-patch-1 branch October 30, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants