Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix imagePullPolicy schema #195

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

tamalsaha
Copy link
Contributor

@tamalsaha tamalsaha commented Oct 24, 2023

What this PR does / why we need it:

Currently imagePullPolicy is marked as an object. It should be a string.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

  • DCO signed
  • Chart Version bumped
  • helm-docs are updated
  • Helm chart is tested
  • Update artifacthub.io/changes in Chart.yaml
  • Run make reviewable

@tamalsaha tamalsaha force-pushed the fix-schema branch 2 times, most recently from 5f707b0 to ea054d3 Compare October 24, 2023 12:11
@stefanprodan
Copy link
Member

stefanprodan commented Oct 24, 2023

@tamalsaha can you please add re-use to the codespell ignore words list in the workflow?

Signed-off-by: Tamal Saha <[email protected]>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @tamalsaha

@stefanprodan stefanprodan merged commit 4da2e85 into fluxcd-community:main Oct 24, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants