Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lint] Test Rule/for direction #20

Closed
wants to merge 8 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 26 additions & 26 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,41 +32,41 @@ jobs:
set -euxo pipefail
yarn install --frozen-lockfile

- name: Cache Pods
uses: actions/cache@v4
id: pods-cache
with:
path: ./ios/Pods
key: ${{ runner.os }}-pods-${{ hashFiles('ios/Podfile.lock') }}
# - name: Cache Pods
# uses: actions/cache@v4
# id: pods-cache
# with:
# path: ./ios/Pods
# key: ${{ runner.os }}-pods-${{ hashFiles('ios/Podfile.lock') }}

- name: Install pods
working-directory: ios
env:
NO_FLIPPER: 1
run: |
set -euxo pipefail
bundle exec pod install
# - name: Install pods
# working-directory: ios
# env:
# NO_FLIPPER: 1
# run: |
# set -euxo pipefail
# bundle exec pod install

- name: Run eslint
run: |
set -euxo pipefail
yarn lint

- name: Run tests
run: |
set -euxo pipefail
yarn test
# - name: Run tests
# run: |
# set -euxo pipefail
# yarn test

- name: Build iOS
run: |
set -euxo pipefail
yarn build-ios
# - name: Build iOS
# run: |
# set -euxo pipefail
# yarn build-ios

- name: Build Android
run: |
set -euxo pipefail
yarn build-android
# - name: Build Android
# run: |
# set -euxo pipefail
# yarn build-android

- name: Fix my build
uses: fly-ci/wingman-action@v1
if: failure()
if: failure()
5 changes: 5 additions & 0 deletions App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,11 @@
function App(): React.JSX.Element {
const isDarkMode = useColorScheme() === 'dark';

/*eslint for-direction: "error"*/
for (var i = 0; i > 10; i++) {

Check failure on line 63 in App.tsx

View workflow job for this annotation

GitHub Actions / ci

The update clause in this loop moves the variable in the wrong direction
console.log(i);
}

const backgroundStyle = {
backgroundColor: isDarkMode ? Colors.darker : Colors.lighter,
};
Expand Down
Loading