Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not fail when there is no Wingman output file #5

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Do not fail when there is no Wingman output file #5

merged 2 commits into from
Jul 29, 2024

Conversation

ligaz
Copy link
Contributor

@ligaz ligaz commented Jul 29, 2024

There are cases when Wingman runs successfully but it does not generate an output file:

  • When the workflows is successful
  • When it is unable to find the log file
  • When a custom GitHub action has failed and Wingman cannot process it

In such cases the action should do nothing instead of failing to generate suggestions.

@ligaz ligaz requested a review from n-valchev July 29, 2024 14:10
@ligaz ligaz self-assigned this Jul 29, 2024
n-valchev
n-valchev previously approved these changes Jul 29, 2024
View reviewed changes
@ligaz ligaz merged commit 63352aa into main Jul 29, 2024
1 check passed
@ligaz ligaz deleted the do-not-fail-when-no-patch branch July 29, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n-valchev n-valchev n-valchev approved these changes

Assignees

@ligaz ligaz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ligaz @n-valchev