Adapt legacy code to new version of application tests infrastructure #24
Conversation
| let response_serialized = serde_json::to_string(&response) | ||
| .map_err(|err| format!("Failed serializing conversion request. {:?}", err))?; | ||
|
|
||
| println!("Successful nitro conversion: {:?}", response_serialized); |
There was a problem hiding this comment.
The string corresponds to a search prefix defined here: https://github.com/fortanix/app-test-infra/blob/5abda4112fb64559eb4e0064cf78dc7e4a29cb0a/python/test_app.py#L1383
|
Which jira ticket requires these changes? Instead of removing the debug image logic completely, shouldn't we be fixing it in another ticket? |
@aditijannu The changes are related to a jira story where I move application tests CI to jenkins (RTE-215). I don't understand how these changes will break ZIrcon if I only touch Salmiac-related code here. About the debug image - it also prevents me from running the app-tests currently as the suffix addition logic prevents the image to be found by app-test code. Also nobody has ever used debug images as this feature wasn't really complete. |
This PR alters the legacy behavior of
container-converterto fit with the new version ofapp-test-infra(https://github.com/fortanix/app-test-infra) when running application tests. In summary the following was done:json serializedconversion response into the stdout. Previously the response was serialized as a simple string and it would break the code in: https://github.com/fortanix/app-test-infra/blob/5abda4112fb64559eb4e0064cf78dc7e4a29cb0a/python/test_app.py#L1005C1-L1008C1debugflag is set to true. This was never realized into a full feature and now breaks the application tests infrastructure code because images with debug prefixes are not supported there. As this feature was never properly implemented and was never needed that much I believe it's best to remove it entirely.DOCKER-AWS-HELPERto be consistent with tool installation path on the executor machine.