ARC: Correction of uImage target build #145
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrodkin
requested changes
Sep 9, 2023
xxkent
force-pushed
the
bolsh-arc64-uImage-fix
branch
from
87c243e to
671ac66
Compare
abrodkin
requested changes
Sep 11, 2023
There was a problem hiding this comment.
Please reword the title to something more meaningful like: "ARCv3: Add missing dependency for uImage" and then in the commit message explain the problem (forget about initial GitHub issue as it won't be visible in a pure git tree, for example when somebody will look at his local source tree) and why that's the right solution.
xxkent
force-pushed
the
bolsh-arc64-uImage-fix
branch
from
671ac66 to
76ea9f0
Compare
Using clean build of uImage target by "make uImage" resulted in an error "'arch/arc/boot/loader': No such file". This was because of "loader" is not dependancy for "uImage". With this fix "make clean"+"make uImage" generate "loader" and "uImage" binaries in "arch/arc/boot/".
Add a GitHub CI test builds to ci.yml for automated testing of uImage building. This adds uImage artifacts files in addition to vmlinux files.
xxkent
force-pushed
the
bolsh-arc64-uImage-fix
branch
from
76ea9f0 to
cba4d85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"uImage" target now have proper dependency on "loader". "make uImage" works properly.
Add a GitHub CI test builds to ci.yml for automated testing of uImage building.