Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Add acceptance tests #139

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

CI: Add acceptance tests #139

wants to merge 5 commits into from

Conversation

qwersem
Copy link
Contributor

@qwersem qwersem commented Feb 7, 2023

PR includes such changes:

  • added acceptance tests to CI with commented failed tests;
  • CI Refactoring;
  • Fix PR autoclosing.

Hi, @BrunoASMauricio, I got following errors from commented tests:

  • (08/21) tests/avocado/machine_arc_mmu.py:ARCMMUTest.test2: FAIL: Unexpected output: [FAIL] MMUv48_02: bunch of bad weather scenario tests for MMUv48\n (0.24 s);
  • (08/19) tests/avocado/machine_arc_mmu.py:ARCMMUTest.test3: INTERRUPTED: Could not perform graceful shutdown\nRunner error occurred: Timeout reached\nOriginal status: ERROR\n{'name': '08-tests/avocado/machine_arc_mmu.py:ARCMMUTest.test3', 'logdir': '/home/runner/work/arc-qemu/arc-qemu/build/tests/results/job-2023-02-04T15.12-1c2d... (2.05 s);
  • (11/20) tests/avocado/machine_arc_mmu.py:ARCMMUTest.test6: FAIL: Unexpected output: [FAIL] MMUv48_06: Test TLB update sequence\n (0.29 s).
    Check me please, maybe need to add something in CI to resolve these fails.

@qwersem
CI: Add acceptance tests and loading logs to CI
e10e387 
This build step runs smoke tests based avocado framework. The test logs are
then uploaded to Workflow Artifacts only for Linux host.

Signed-off-by: Evgeny Semenov <[email protected]>
@qwersem
CI: Remove unnecessary explicit "git fetch" command in CI
866caa1 
Actions/checkout resolve the same task and even more.

Signed-off-by: Evgeny Semenov <[email protected]>
@qwersem
CI: Fix PR autoclosing
a605593 
- Update repo-lockdown action;
- Comment PR autoclosing;

Signed-off-by: Evgeny Semenov <[email protected]>
@qwersem
Raise timeout for boot_linux_console arc tests
953eee1 
Signed-off-by: Evgeny Semenov <[email protected]>
@qwersem qwersem added enhancement New feature or request question Further information is requested labels Feb 7, 2023
@qwersem qwersem self-assigned this Feb 7, 2023
@github-actions github-actions bot closed this Feb 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2023
@qwersem qwersem linked an issue Feb 7, 2023 that may be closed by this pull request
CI: Add acceptance tests to ci.yml #135
Closed
@qwersem qwersem reopened this Feb 7, 2023
@qwersem
Copy link
Contributor Author

qwersem commented Feb 7, 2023

This PR has been closed here because changes will work after the merge.
qwersem#13 is example which doesn't have PR auto-closing feature.

@qwersem qwersem requested a review from shahab-vahedi February 7, 2023 15:17
@BrunoASMauricio
Copy link
Contributor

Hello @qwersem . Those tests are indeed failing, but it has nothing to do with CI. For the most part they are internal problems we have yet to fix with Qemu.

@qwersem
Copy link
Contributor Author

qwersem commented Feb 7, 2023

Ok, @BrunoASMauricio, need to uncomment tests?

@qwersem qwersem marked this pull request as draft February 8, 2023 09:20
@BrunoASMauricio
Copy link
Contributor

I understand the problem now. Let us use a side channel to discuss this matter before making a decision. Please keep this PR open

@qwersem
Copy link
Contributor Author

qwersem commented Feb 8, 2023

Yes, sure

@qwersem qwersem force-pushed the 135-qwersem-add-acceptance-tests-to-ci branch from 15b280c to d381e8e Compare March 2, 2023 13:16
@qwersem qwersem marked this pull request as ready for review March 2, 2023 13:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abrodkin abrodkin Awaiting requested review from abrodkin

@claziss claziss Awaiting requested review from claziss

@BrunoASMauricio BrunoASMauricio Awaiting requested review from BrunoASMauricio

@shahab-vahedi shahab-vahedi Awaiting requested review from shahab-vahedi

Assignees

@qwersem qwersem

Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: Add acceptance tests to ci.yml
2 participants
@qwersem @BrunoASMauricio