fix: maintain existing discounts in get_pricing_rule_for_item #45345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sanket322
force-pushed
the
set_discount_properly
branch
from
16352d3 to
e2a32b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes : Support Ticket - 29277
Related PR: #44708
Issue:
Previously, when the get_pricing_rule_for_item method was triggered due to a change in quantity, it reset both discount_amount and discount_percentage to 0, regardless of existing values.
Fix:
The method now checks if the first argument contains discount_amount and discount_percentage. If available, it uses those values; otherwise, it defaults to 0.