-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CLAP libs and support preset-load extension #141
Conversation
This looks good except for the ci errors. But two thoughts
|
Yeah, I can fix the Projucer errors.
Sounds good to me!
Yeah, for preset discovery I implement my own factory (as we discussed in #125). I had thought about trying to add a "generic" implementation to CJE, but the only way I could think to do that would be through the |
Ok 100% agree. So then let’s wait for 1.2, fix ci, and then merge this. Then I can implement the non draft discovery and load in surge! |
Oh the other thing I would add once we do the 1.2 then merge plan is: a function pointer for the host I think Alex is tagging 1.2 on monday so we can do all of that then! |
- include a check in clap wrappers to make sure we are there
The main idea here is to support the
preset-load
extension. However, to do that properly, I had to update clap-helpers (see free-audio/clap-helpers#19). I ended up just pulling both the clap-helpers and clap submodules up to their HEADs. If folks aren't comfortable with that, I'd be happy to back out to an earlier version, so long as it contains the relevant changes.I also made a tweak to the CMake so that various global CLAP definitions (e.g.CLAP_ID
,CLAP_FEATURES
, etc) are exposed to the plugin code, since I foundCLAP_ID
to be useful in my own implementation ofpreset-load
. Again, we might not want to make all of these definitions public, so that's maybe something we should talk about.The
preset-load
changes themselves are pretty straightforward, and follow the pattern that we've used for the other CLAP "extended" capabilities. BYOD has supportedpreset-load
using this branch since version 1.2.0, so that might be a useful example for folks.