Cleanup filters/Speed up local build #499
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anneke Sinnema <[email protected]>
Signed-off-by: Anneke Sinnema <[email protected]>
anneke
requested review from
SleeplessByte and
maniflames
and removed request for
a team
edwinm
approved these changes
Jan 2, 2025
SleeplessByte
approved these changes
Jan 2, 2025
Comment on lines
+235
to
+236
| const inputDir = 'dist/assets/images/social-preview-images/'; | ||
| const outputDir = 'dist/assets/images/social-preview-images/'; |
There was a problem hiding this comment.
This is using fs, so this needs to use path.join('...', '...', '...');.
You may want to update the path and fs import to node: to prevent any package from providing those features down the line (security).
| readablePostDate(dateObj) { |
There was a problem hiding this comment.
Is this the new syntax to provide filters?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little bit of cleanup to make best use of Claudia's earlier refactoring of a seperate filters.js file.