Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pytest fixtures to serve the test data #109

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

cmalinmayor
Copy link
Contributor

Closes #106

@cmalinmayor cmalinmayor linked an issue Jul 24, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.47%. Comparing base (1667678) to head (20d6f95).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
- Coverage   93.74%   93.47%   -0.27%     
==========================================
  Files          33       32       -1     
  Lines         815      782      -33     
==========================================
- Hits          764      731      -33     
  Misses         51       51              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmalinmayor
Copy link
Contributor Author

The coverage percent goes down very slightly because the test data was considered "tested" code previously, and now it is not. This is fine.

@cmalinmayor cmalinmayor merged commit 3afd9ac into main Jul 24, 2024
12 of 13 checks passed
@cmalinmayor cmalinmayor deleted the 106-pytest-fixtures branch July 24, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use pytest fixtures when loading test data
1 participant