fix: qbd direct advanced settings post onboarding fix

[DhaaraniCIT]

Description

fix: qbd direct advanced settings post onboarding fix

Clickup

https://app.clickup.com/t/

Summary by CodeRabbit

• Bug Fixes
  • Updated back button visibility in advanced settings to dynamically show/hide based on onboarding state

[coderabbitai]

Walkthrough

The pull request modifies the qbd-direct-advanced-settings.component.html file, specifically updating the showBackButton property of the app-configuration-step-footer component. The change introduces a conditional rendering of the back button based on the isOnboarding variable, replacing a previous unconditional true setting. This adjustment allows dynamic control over the back button's visibility during the onboarding process.

Changes

File	Change Summary
src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-advanced-settings/qbd-direct-advanced-settings.component.html	Modified showBackButton to conditionally render based on isOnboarding

Possibly related PRs

• fix: qbd direct connection phase fix #1155: Modifications to the QbdDirectOnboardingConnectorComponent related to the onboarding process

Suggested labels

size/XS

Suggested reviewers

• ashwin1111
• Hrishabh17

Poem

🐰 A button's fate, now dynamic and bright
Onboarding's path, with logic just right
Back and forth, the rabbit hops with glee
Conditional rendering, setting buttons free!
A small change that makes the workflow neat 🎉

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-advanced-settings/qbd-direct-advanced-settings.component.html (1)

138-138: Simplify the boolean expression.

The ternary operator isOnboarding ? true : false can be simplified to just isOnboarding since it already returns a boolean value.

-            <app-configuration-step-footer [ctaText]="!saveInProgress ? (isOnboarding ? ConfigurationCtaText.SAVE_AND_CONTINUE : ConfigurationCtaText.SAVE) : ConfigurationCtaText.SAVING" [isButtonDisabled]="!advancedSettingsForm.valid || saveInProgress || !skipExportForm.valid" (save)="save()" [showBackButton]="isOnboarding ? true : false" (navigateToPreviousStep)="navigateToPreviousStep()"></app-configuration-step-footer>
+            <app-configuration-step-footer [ctaText]="!saveInProgress ? (isOnboarding ? ConfigurationCtaText.SAVE_AND_CONTINUE : ConfigurationCtaText.SAVE) : ConfigurationCtaText.SAVING" [isButtonDisabled]="!advancedSettingsForm.valid || saveInProgress || !skipExportForm.valid" (save)="save()" [showBackButton]="isOnboarding" (navigateToPreviousStep)="navigateToPreviousStep()"></app-configuration-step-footer>

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1d05001 and 8133ad4.

📒 Files selected for processing (1)

• src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-advanced-settings/qbd-direct-advanced-settings.component.html (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: unit-test

🔇 Additional comments (1)

src/app/integrations/qbd-direct/qbd-direct-shared/qbd-direct-advanced-settings/qbd-direct-advanced-settings.component.html (1)

138-138: LGTM! The back button visibility logic aligns with the PR objectives.

The change correctly shows the back button only during onboarding and hides it post-onboarding, which fixes the advanced settings behavior after the onboarding process.

[github-actions]

Unit Test Coverage	%	values
Statements	33.04%	( 4136 / 12517 )
Branches	26.46%	( 1180 / 4458 )
Functions	25.62%	( 894 / 3489 )
Lines	33.22%	( 4070 / 12248 )