use get method instead of Index brackets (#153)

fylein · Apr 1, 2024 · c502c87 · c502c87
1 parent 7cb65ac
commit c502c87
Show file tree

Hide file tree

Showing 4 changed files with 209 additions and 204 deletions.
diff --git a/apps/sage300/dependent_fields.py b/apps/sage300/dependent_fields.py
@@ -84,6 +84,8 @@ def post_dependent_cost_code(dependent_field_setting: DependentFieldSetting, pla
 
     for project in projects:
         payload = []
+        cost_code_names = []
+
         for cost_code in project['cost_codes']:
             if project['job_name'] in existing_projects_in_fyle:
                 payload.append({
@@ -93,9 +95,12 @@ def post_dependent_cost_code(dependent_field_setting: DependentFieldSetting, pla
                     'expense_field_value': cost_code,
                     'is_enabled': True
                 })
-                sleep(0.2)
-                platform.dependent_fields.bulk_post_dependent_expense_field_values(payload)
-                posted_cost_codes.append(cost_code)
+                cost_code_names.append(cost_code)
+
+        if payload:
+            sleep(0.2)
+            platform.dependent_fields.bulk_post_dependent_expense_field_values(payload)
+            posted_cost_codes.append(cost_code_names)
 
     return posted_cost_codes
 
@@ -131,7 +136,6 @@ def post_dependent_expense_field_values(workspace_id: int, dependent_field_setti
         filters['updated_at__gte'] = dependent_field_setting.last_successful_import_at
 
     posted_cost_types = post_dependent_cost_code(dependent_field_setting, platform, filters)
-
     if posted_cost_types:
         filters['cost_code_name__in'] = posted_cost_types
         post_dependent_cost_type(dependent_field_setting, platform, filters)

diff --git a/apps/sage300/utils.py b/apps/sage300/utils.py
@@ -79,14 +79,15 @@ def _sync_data(self, data, attribute_type, display_name, workspace_id, field_nam
         destination_attributes = []
         for item in data:
             detail = {field: getattr(item, field) for field in field_names}
-            destination_attributes.append(self._create_destination_attribute(
-                attribute_type,
-                display_name,
-                item.name,
-                item.id,
-                item.is_active,
-                detail
-            ))
+            if item.name:
+                destination_attributes.append(self._create_destination_attribute(
+                    attribute_type,
+                    display_name,
+                    item.name,
+                    item.id,
+                    item.is_active,
+                    detail
+                ))
 
         DestinationAttribute.bulk_create_or_update_destination_attributes(
             destination_attributes, attribute_type, workspace_id, True)