Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document the way to use gendex and dex.go for new GoNativeActivity.java behaviour #5387

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dolanor
Copy link

@dolanor dolanor commented Jan 9, 2025

No description provided.

Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: We are planning on deprecating this tool here in favour of moving it into https://github.com/fyne-io/tools. I think I changed how the generation is done in that project.

Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great additions thanks, but I think one of the docs is a bit misleading.

@@ -27,6 +27,11 @@
import android.widget.TextView;
import android.widget.TextView.OnEditorActionListener;

// GoNativeActivity is the java implementation that helps Go map to android via the NDK.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this first sentence is right - the activity is the entry point for our Android boot loader.
The NDK connects to this via C - so it's not really providing any connections itself I don't think?...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I meant (from my VERY limited understanding) is that it was the java SDK object that was a utility for Go to access via the C and the NDK.
I guess I don't know how to express it correctly :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go accesses the Java object via NDK. The Java provides us certain functionality which is accessed through JNI and C functionality.
Is that clearer?

@dolanor
Copy link
Author

dolanor commented Jan 9, 2025

Ok.

What's the new procedure to generate a new dex, then?
I kind of need it

@andydotxyz
Copy link
Member

Ok.

What's the new procedure to generate a new dex, then? I kind of need it

We are in the process of moving cmd/fyne into the tools repo, but nothing else changes. So this could/should land as I believe the tools repo is pending a merge as things have got behind again. Is that about right @sdassow ?

@coveralls
Copy link

Coverage Status

coverage: 60.01% (-0.005%) from 60.015%
when pulling a3cfe7b on dolanor:master
into 4a875d9 on fyne-io:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants