Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add entrypoint option to docker.compose.run() (#659) #661

Merged
merged 2 commits into from
Dec 25, 2024
Merged

Add entrypoint option to docker.compose.run() (#659) #661

merged 2 commits into from
Dec 25, 2024

Conversation

www84
Copy link
Contributor

@www84 www84 commented Dec 23, 2024

PR for the entrypoint part of #659, a second PR follows if this is merged successfully.

gabrieldemarmiesse
gabrieldemarmiesse requested changes Dec 25, 2024
View reviewed changes
Copy link
Owner

@gabrieldemarmiesse gabrieldemarmiesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice pull request, just a small fix, but I should be able to push it myself.

python_on_whales/components/compose/cli_wrapper.py Outdated Show resolved Hide resolved
@gabrieldemarmiesse gabrieldemarmiesse enabled auto-merge (squash) December 25, 2024 09:43
@gabrieldemarmiesse gabrieldemarmiesse merged commit 86804ee into gabrieldemarmiesse:master Dec 25, 2024
21 checks passed
@www84 www84 deleted the add-entrypoint-option-to-compose-run branch December 25, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrieldemarmiesse gabrieldemarmiesse gabrieldemarmiesse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@www84 @gabrieldemarmiesse