Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade go to v1.21, enable image data piping #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kheina
Copy link

@kheina kheina commented Mar 7, 2024

  • upgrades go to v1.21 and eliminates the use of imax in favor of go's built-in max function
  • imports gif and webp libraries to add support for those file types
  • reworks cmd/thumbhash/main.go slightly to add support for piping image data directly to thumbhash encode-image for better interoperability

@galdor
Copy link
Owner

galdor commented Mar 9, 2024

The first patch mixes the Go version update with other unrelated changes. if you send me a patch with just the bump to 1.21 (and you could even go to 1.22) and the use of the builtins min and max, I'll apply it.

For the second patch, it seems like a good idea but a quick read shows a couple minor issues (e.g. if the argument is now optional, why would you make it mandatory in readFilePath?). I'll see what I can do when I get the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants