Refactor Projection to not use KeyDependentOperation #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing that causes warnings in all other GAP packages that install methods for `Projection`. Since there seem to be no tests or examples or documentation covering this function, I added a new test to verify it works as before.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #13 +/- ##
==========================================
+ Coverage 57.66% 58.86% +1.20%
==========================================
Files 43 43
Lines 9248 9253 +5
==========================================
+ Hits 5333 5447 +114
+ Misses 3915 3806 -109
|
|
@dsavchuk @muntyan do these change seem reasonable to you? If so, it would be great to get this and my other pull request #12 merged and put into a new release of this package. I'd be happy to take care of doing that (it'd take me maybe 10 minutes of work, most of which would be spent on updating the NEWS file ;-) ) |
|
Dear Max,
My apologies for the delay and thank you for your suggestion - of course,
this change is perfectly fine. I am not sure now why it was written with a
recursion back then. We will really appreciate it if you could update it on
your end.
Best Wishes,
Dmytro
…On Thu, Jan 2, 2025 at 5:46 PM Max Horn ***@***.***> wrote:
@dsavchuk <https://github.com/dsavchuk> @muntyan
<https://github.com/muntyan> do these change seem reasonable to you?
If so, it would be great to get this and my other pull request #12
<#12> merged and put into a
new release of this package.
I'd be happy to take care of doing that (it'd take me maybe 10 minutes of
work, most of which would be spent on updating the NEWS file ;-) )
—
Reply to this email directly, view it on GitHub
<#13 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANIGXEN2GFWFZQCZY6QP3E32IW6S5AVCNFSM6AAAAABUQWO6T2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRYGQ3TGNRSHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
OK I've merged the changes and will make a new release. Thanks! |
|
Thank you very much, Max!
Dmytro
…On Wed, Jan 8, 2025 at 3:30 PM Max Horn ***@***.***> wrote:
OK I've merged the changes and will make a new release. Thanks!
—
Reply to this email directly, view it on GitHub
<#13 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANIGXENQVQXFQ4ENZHOX6LT2JWDE3AVCNFSM6AAAAABUQWO6T2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZYGU4TONJQGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing that causes warnings in all other GAP packages that install
methods for
Projection.Since there seem to be no tests or examples or documentation covering
this function, I added a new test to verify it works as before.