WIP: Attempt to unify building some of the containers #3
Conversation
| && make install | ||
|
|
||
| # Macaulay2 | ||
| RUN echo "deb http://www.math.uiuc.edu/Macaulay2/Repositories/Ubuntu $(lsb_release -sc) main" >/etc/apt/sources.list.d/macaulay2.list \ |
There was a problem hiding this comment.
ah but that one requires Ubuntu 21.10, which isn't an LTS release. But of course 22.04 is also going to be released in the not so distant future, and will be an LTS... and I am not even sure whether it matters that much for us?
There was a problem hiding this comment.
it seems it might be available in 21.04 according to http://www2.macaulay2.com/Macaulay2/Downloads/GNU-Linux/Ubuntu/index.html - I could move the current image to hirsute and get it installed via the package manager if you think that's worthwhile?
|
Just FYI @fingolfin, I haven't written a single line of the |
|
Yeah, that's fine -- my thought was that at some point, someone (you, me, someone else, doesn't matter) might want to pick up this PR and then it'd be useful to leave my remarks here for them, that's all :-) |
|
Just had a chance to have a look at and edit the Dockerfile for these comments - however I can't seem to commit anything to this PR :/ not 100% sure what the issue is but it might be something to do with my permissions for the repository itself? @wilfwilson |
|
@ZachNewbery I just gave you write access to this repo, this should allow you to push to the PR |
|
Perfect, I've just pushed my changes! |
|
Thanks for looking at this @ZachNewbery, please feel free to change this PR however you want |
So for, this publishes
gap-docker-masterandgap-docker-stable-4.11using the sameDockerfileand the same GitHub Actions workflow.I will see what I can do to build and push more of the images with as little code duplication as possible.