FIX: wreath product with trivial group contains trivial generators #5826
Conversation
Generators should not contain the identity element, unless the group is trivial.
FriedrichRober
added
the
kind: quirk
| fi; | ||
| # generators for the cases where one component is trivial | ||
| if IsTrivial(A) and IsTrivial(B) then | ||
| g := Group( One(A) ); |
There was a problem hiding this comment.
How about just
| g := Group( One(A) ); | |
| g := A: |
or if one really wants a new group:
| g := Group( One(A) ); | |
| g := TrivialSubgroup( A ); |
| gens1 := [ One(G) ]; | ||
| basegens := ShallowCopy(gens1); |
There was a problem hiding this comment.
Does taking an empty list here not work?
|
ping @FriedrichRober |
|
@FriedrichRober last call for GAP 4.14 ... |
|
Oh my sincere apologies, I was swallowed in other work and forgot about it.
You are right. I thought it was breaking something in my package WPE, but actually the bug was hidden somewhere else. Nevertheless, I already have put some work into it, so I wanted to finish cleaning up the redundant generators. This being said, if it doesn’t make it into 4.14, it’s not a huge deal, since it isn’t a breaking bug. I will try to make it in time though. |
Generators of wreath products should not contain the identity element, unless the group is trivial.
Text for release notes
see title
Further details