Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to use mapboxgl map plugin in NavSat Map gui plugin #520

Closed
wants to merge 1 commit into from

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Mar 9, 2023

🦟 Bug fix

Fixes #482

Summary

Using the osm map plugin in the NavSat gui plugin seems to cause the window to freeze / crash. Switched to use mapboxgl instead.

Now it works for me:

navsat_mapboxgl

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 requested a review from jennuine as a code owner March 9, 2023 21:14
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Mar 9, 2023
@iche033 iche033 changed the title Switch to use mapboxgl map plugin in NavSat gui plugin Switch to use mapboxgl map plugin in NavSat Map gui plugin Mar 9, 2023
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #520 (2fe5353) into ign-gui6 (eef51bf) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 2fe5353 differs from pull request most recent head 293703e. Consider uploading reports for the commit 293703e to get more accurate results

@@             Coverage Diff              @@
##           ign-gui6     #520      +/-   ##
============================================
+ Coverage     68.06%   68.10%   +0.03%     
============================================
  Files            39       39              
  Lines          5327     5327              
============================================
+ Hits           3626     3628       +2     
+ Misses         1701     1699       -2     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@azeey
Copy link
Contributor

azeey commented Mar 9, 2023

From reading https://doc.qt.io/qt-5/location-plugin-mapboxgl.html, it says

Both Mapbox geo services plugins require an access token to access map styles and tiles hosted by Mapbox.

and the documentation on mabpoxgl.access_token says

Access token provided by Mapbox. The token can also be specified using the environment variable MAPBOX_ACCESS_TOKEN, but if also set using a plugin parameter, then this last one will have the precedence over the environment variable. When not set, a development token will be used by default. The development token is subject to the Mapbox Terms of Services and must not be used in production. This property has no effect on styles hosted outside the Mapbox servers.

So it's not clear to me if we're allowed to use it.

@jennuine
Copy link
Contributor

jennuine commented Mar 9, 2023

Also, when the box is moved using the transform tool, the GUI freezes up still :(

@iche033
Copy link
Contributor Author

iche033 commented Mar 9, 2023

hmm ok closing as it's not clear if we can use the plugin and it also does not completely fix the issue.

@iche033 iche033 closed this Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants