Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use constexpr instead of #define #1598

Merged
merged 3 commits into from
Jan 4, 2025
Merged

Conversation

Rangi42
Copy link
Contributor

@Rangi42 Rangi42 commented Jan 4, 2025

This allows for typechecking, avoids expansion precedence issues, and continues in the vein of replacing C idioms with C++ (when it's zero-cost and safer, simpler, more robust, or otherwise better to do so).

@Rangi42 Rangi42 added rgbasm This affects RGBASM refactoring This PR is intended to clean up code more than change functionality labels Jan 4, 2025
@Rangi42 Rangi42 added this to the 0.9.1 milestone Jan 4, 2025
@Rangi42 Rangi42 requested a review from ISSOtm January 4, 2025 02:20
@Rangi42 Rangi42 changed the title Use a constexpr instead of #define LEXER_BUF_SIZE Use constexpr instead of #define Jan 4, 2025
@Rangi42 Rangi42 added rgblink This affects RGBLINK rgbfix This affects RGBFIX rgbgfx This affects RGBGFX labels Jan 4, 2025
@Rangi42 Rangi42 removed the request for review from ISSOtm January 4, 2025 08:52
@Rangi42 Rangi42 merged commit d977342 into gbdev:master Jan 4, 2025
23 checks passed
@Rangi42 Rangi42 deleted the lexer-buf-size branch January 4, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring This PR is intended to clean up code more than change functionality rgbasm This affects RGBASM rgbfix This affects RGBFIX rgbgfx This affects RGBGFX rgblink This affects RGBLINK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant