feat(cli): integrate sails-js-cli into sails-cli #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breathx
approved these changes
Sep 12, 2024
vobradovich
reviewed
Sep 13, 2024
| @@ -12,6 +12,26 @@ struct CargoCommands { | |||
| enum SailsCommands { | |||
| #[command(name = "sails", subcommand)] | |||
| Sails(Commands), | |||
| #[command(name = "sails-js", subcommand)] | |||
| SailsJs(JsCommands), | |||
There was a problem hiding this comment.
That won't work.
Only one command sails per cargo-sails executable.
| #[derive(Subcommand)] | ||
| enum JsCommands { | ||
| #[command(name = "generate-client")] | ||
| GenerateClient { |
There was a problem hiding this comment.
it is better to make js-client under sails, like
cargo sails js-client service.idl
DennisInSky
requested changes
Sep 20, 2024
Comment on lines
+38
to
+43
| .expect("Failed to run npx sails-js-cli"); | ||
|
|
||
| let status = child.wait().expect("An error occured"); | ||
|
|
||
| if !status.success() { | ||
| panic!("Failed to generate JS client"); |
There was a problem hiding this comment.
Please instead of using panic, expect, etc., use Result to return the error s it can printed out by the program in standard way. This comment is applicable to the entire mod
| } | ||
| } | ||
|
|
||
| pub fn check_app_installed(app: &str) -> bool { |
| .unwrap_or(false) | ||
| } | ||
|
|
||
| pub fn check_node() -> Result<()> { |
| Ok(()) | ||
| } | ||
|
|
||
| pub fn check_npx() -> Result<()> { |
| @@ -12,6 +12,26 @@ struct CargoCommands { | |||
| enum SailsCommands { | |||
| #[command(name = "sails", subcommand)] | |||
| Sails(Commands), | |||
| #[command(name = "sails-js", subcommand)] | |||
| SailsJs(JsCommands), | |||
| #[derive(Subcommand)] | ||
| enum JsCommands { | ||
| #[command(name = "generate-client")] | ||
| GenerateClient { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.