feat(telemetry): Add telemetry via @sentry/node
#213
Conversation
andreiborza
force-pushed
the
ab/add-telemetry
branch
from
fd74f0a to
00a2e24
Compare
andreiborza
force-pushed
the
ab/add-telemetry
branch
from
00a2e24 to
2839b6b
Compare
src/telemetry.ts
Outdated
| event.exception?.values?.forEach(exception => { | ||
| delete exception.stacktrace; | ||
| }); |
There was a problem hiding this comment.
I'm wondering if this is even necessary in the action? Can it run anywhere else than on github's environment? Our main objective for deleting the stack trace in the wizard and plugins was that the stack trace file paths would likely come from users' devices.
Happy with either way, just wanted to ask if it's necessary.
There was a problem hiding this comment.
People could theoretically, for whatever reason, execute this action via something like https://github.com/nektos/act but I think the chance is rather low.
Will remove.
There was a problem hiding this comment.
Removed the hooks as well for the same reason.
src/main.ts
Outdated
| }, | ||
| async () => { | ||
| try { | ||
| const cli = getCLI(); |
There was a problem hiding this comment.
l/suggestion: In the bundler plugins, we pass the trace to the CLI. Maybe worth to do this here as well?
andreiborza
force-pushed
the
ab/add-telemetry
branch
from
590975a to
b9f36f1
Compare
andreiborza
force-pushed
the
ab/add-telemetry
branch
from
72f6dfe to
248798c
Compare
|
@Lms24 I added session tracking and the |
andreiborza
force-pushed
the
ab/add-telemetry
branch
2 times, most recently
from
586f67a to
248798c
Compare
andreiborza
force-pushed
the
ab/add-telemetry
branch
from
faeb117 to
93f5b5e
Compare
andreiborza
force-pushed
the
ab/add-telemetry
branch
from
dca951d to
202993b
Compare
andreiborza
force-pushed
the
ab/add-telemetry
branch
from
0105914 to
202993b
Compare
| }).releases; | ||
|
|
There was a problem hiding this comment.
Just to confirm: the for loop for setting the variables was moved to checkEnvironmentVariables, right?
There was a problem hiding this comment.
Yep, correct. That was really only necessary once at startup and since getCli is now not returning a singleton anymore I moved it over there.
Adds telemetry by setting up a barebones Sentry instance using
@sentry/node. Individual steps can be traced by wrapping them with thetraceStephelper.Here's an example of an execution:
Closes: #214