Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize minimum version checking #3910

Merged
merged 7 commits into from
Jan 9, 2025

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Jan 9, 2025

For populating tox automatically, we need to store min versions of frameworks/libraries in a programmatically accessible place.

The obvious place for this would be in each integration; however, since integrations can't be imported unless the respective framework is installed, this couldn't be used from the script (unless we'd always install all requirements of all integrations prior to running it, which takes a non trivial amount of time). So instead I've opted for a central place within sentry_sdk/integrations/__init__.py.

Note: the min versions probably need updating. Not sure when this was last done, but some of them look quite ancient and we probably don't support them because we'd already dropped the last Python version they'd be able to run on.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 88.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.21%. Comparing base (4432e26) to head (d16a497).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/integrations/__init__.py 40.00% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3910      +/-   ##
==========================================
+ Coverage   79.83%   80.21%   +0.37%     
==========================================
  Files         140      140              
  Lines       15451    15412      -39     
  Branches     2625     2593      -32     
==========================================
+ Hits        12335    12362      +27     
+ Misses       2240     2207      -33     
+ Partials      876      843      -33     
Files with missing lines Coverage Δ
sentry_sdk/integrations/aiohttp.py 80.11% <100.00%> (+1.90%) ⬆️
sentry_sdk/integrations/anthropic.py 84.70% <100.00%> (+2.04%) ⬆️
sentry_sdk/integrations/ariadne.py 87.50% <100.00%> (+3.98%) ⬆️
sentry_sdk/integrations/arq.py 89.84% <100.00%> (+2.82%) ⬆️
sentry_sdk/integrations/asyncpg.py 91.07% <100.00%> (+1.69%) ⬆️
sentry_sdk/integrations/boto3.py 82.27% <100.00%> (+4.22%) ⬆️
sentry_sdk/integrations/bottle.py 84.90% <100.00%> (+3.25%) ⬆️
sentry_sdk/integrations/celery/__init__.py 86.55% <100.00%> (+0.78%) ⬆️
sentry_sdk/integrations/clickhouse_driver.py 91.76% <100.00%> (+2.22%) ⬆️
sentry_sdk/integrations/django/__init__.py 81.48% <100.00%> (+0.47%) ⬆️
... and 11 more

... and 5 files with indirect coverage changes

@sentrivana sentrivana marked this pull request as ready for review January 9, 2025 14:12
@sentrivana sentrivana merged commit be53273 into master Jan 9, 2025
138 checks passed
@sentrivana sentrivana deleted the ivana/centralize-version-checks branch January 9, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants