PP 835 updating libraries #628
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld-the-Health-SDK-to-use-the-basis-SDK-removing-all-duplications
…nfiguration`, `paymentComponentPreferences` and `paymentComponentView` from `HealthSDK`, to use the ones in `internal-payment-sdk` IPC-327
…ch are in basis sdk
…l` to be able to run the app - Changed `ReviewFragment` implementation to use `internal-payment-sdk` IPC-327
- load payment details via `GiniInternalPaymentModule` IPC-327
…l-payment-sdk` into `HealthSDK` IPC-327
…nal-payment-sdk`' of https://github.com/gini/gini-mobile-android into refactor(health-sdk)-use-`paymentComponent`-from-`internal-payment-sdk`
…nent` from `GiniPaymentManager` IPC-327
…nal-payment-sdk`' of https://github.com/gini/gini-mobile-android into refactor(health-sdk)-use-`paymentComponent`-from-`internal-payment-sdk`
… to `GiniInternalPaymentModule` IPC-343
…nal-payment-sdk`' into IPC-327-Rebuild-the-Health-SDK-to-use-the-basis-SDK-removing-all-duplications * refactor(health-sdk)-use-`paymentComponent`-from-`internal-payment-sdk`: (22 commits) fix(health-sdk): Review test fix fix(basis-sdk): Test and detekt fixes fix(basis-sdk): Fixed custom localization setting fix(basis-sdk): Fixed ids and review fragment test refactor(health-sdk): Removed unused layout files fix(health-sdk): Test fixes refactor(health-sdk): Fix for custom localization fix(health-sdk): Fix `paymentComponent` rows in `GiniHealthSdk` refacotor(health-sdk): Fixes for example app refactor(internal-payment-sdk): Addressed `detekt` issues refactor(health-sdk): Refactored tests refactr(health-sdk): Moved payment details validation to `ReviewComponent` from `GiniPaymentManager` refactor(health-sdk): Finalised integration of `Review` from `internal-payment-sdk` into `HealthSDK` refactor(health-sdk): Sorted Review related tests between health and internal sdk refactor(health-sdk): Switched to `ReviewView` in `ReviewFragment` refactor(health-sdk): Removed duplicate tests and fixed them in internal sdk refactor(health-sdk): Updated `InvoicesActivity` and `InoicesViewModel` to be able to run the app refactor(health-sdk): Updates and fixes for Review and PaymentComponentView refactor(health-sdk): Changed classes in example app to use internal-sdk refactor(health-sdk): Removed 'Open with' classes to use them from internal-sdk ...
…sis-SDK-removing-all-duplications * main: (179 commits) fix(merchant-sdk): Removed unused empty class feat(health-sdk): Bump version to 4.4.0 feat(health-api-library): Bump version to 4.4.0 ci: Remove push trigger on gpc app PM-117 feat(bank-sdk): Add bank icon for gpc module PM-119 ci: Add workflow for gini payment controller PM-117 feature(bank-sdk): Transaction Docs. Added delete button at Invoice Preview screen feature(bank-sdk): Transaction Docs. Added delete button at Invoice Preview screen fix(capture-sdk): Make sure that frame will not be closed before all image detection finished PP-823 feat(bank-sdk): Bump version to 3.14.0 feat(capture-sdk): Bump version to 3.12.0 feat(bank-api-library): Bump version to 3.3.0 feature(bank-sdk): Transaction Docs. Code refactor feat(health-sdk): Doc fix feat(health-sdk): Example app update to show medical provider on invoice list feat(health-sdk): Made specific extractions public so doctor's name could be reached feature(bank-sdk): Transaction Docs. Code refactor feature(bank-sdk): Transaction Docs. Added backward compability constructors feature(bank-sdk): Transaction Docs. Removed useless library feature(bank-sdk): Transaction Docs. Tests fix ... # Conflicts: # RELEASE-ORDER.md # health-sdk/example-app/src/main/java/net/gini/android/health/sdk/exampleapp/review/ReviewActivity.kt # health-sdk/sdk/src/test/java/net/gini/android/health/sdk/GiniHealthTest.kt
IPC-490
Ipc 490 update docs and code
# Conflicts: # bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/skonto/SkontoFragment.kt
abolfazlimahdi
requested changes
Dec 3, 2024
There was a problem hiding this comment.
Looks good. Thank you! Only two points:
- Can you please refactor the libs.versions file and extract the libraries that are added without separate versions like:
androidx-core-ktx = "androidx.core:core-ktx:1.14.0-alpha01" - It would be great to have a look at changes that come with major versions of Kotlin and AGP. We also want to notify our clients about upgrading these two libraries in the future.
feature(bank-sdk): Skonto + RA validation implementation
…ke this file consistent [PP-835]
…layout, view pager and material dependencies version [PP-835]
…ore and coroutine related dependencies version [PP-835]
…ted json library used with same version. [PP-835]
…st and downgrading bom version of compose because it needs some code changes [PP-835]
[PP-835]
…PP-835-updating-libraries # Conflicts: # gradle/libs.versions.toml
|
abolfazlimahdi
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.