Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow loading in Page and Group components #146

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

ecarreras
Copy link
Member

This pull request includes changes to refactor the Group and Page classes to extend from the Spinner class instead of ContainerWidget, and updates the corresponding tests to verify the new behavior. The most important changes include modifying the class inheritance and adding tests to validate the loading property.

Class inheritance changes:

  • src/Group.ts: Changed the Group class to extend from Spinner instead of ContainerWidget.
  • src/Page.ts: Changed the Page class to extend from Spinner instead of ContainerWidget.

Test updates:

@ecarreras ecarreras added the enhancement New feature or request label Dec 5, 2024
@ecarreras ecarreras self-assigned this Dec 5, 2024
@ecarreras ecarreras merged commit 2e4b523 into v2 Dec 9, 2024
1 check passed
@ecarreras ecarreras deleted the container-spinner branch December 9, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant