Allow loading in Page and Group components #146
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to refactor the
Group
andPage
classes to extend from theSpinner
class instead ofContainerWidget
, and updates the corresponding tests to verify the new behavior. The most important changes include modifying the class inheritance and adding tests to validate theloading
property.Class inheritance changes:
src/Group.ts
: Changed theGroup
class to extend fromSpinner
instead ofContainerWidget
.src/Page.ts
: Changed thePage
class to extend fromSpinner
instead ofContainerWidget
.Test updates:
src/spec/Group.spec.ts
: Added tests to verify theloading
property behavior in theGroup
class.src/spec/Page.spec.ts
: Added tests to verify theloading
property behavior in thePage
class.