Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move fieldType to widget when we use widgets as fields #149

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

ecarreras
Copy link
Member

This pull request involves refactoring the Field and Widget classes to improve code organization by moving the _fieldType property and its related logic from the Field class to the Widget class.

Refactoring changes:

  • src/Field.ts: Removed the _fieldType property and its getter method from the Field class. Additionally, removed the logic that sets _fieldType based on props.type. [1] [2]
  • src/Widget.ts: Added the _fieldType property and its getter method to the Widget class. Also, included the logic to set _fieldType based on props.type. [1] [2]

@ecarreras ecarreras merged commit a1c1dd4 into v2 Dec 10, 2024
1 check passed
@ecarreras ecarreras deleted the dynamic-alert branch December 10, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants