Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mingw-w64-git-lfs: update to 3.4.1 #537

Merged
merged 1 commit into from
Dec 14, 2023
Merged

mingw-w64-git-lfs: update to 3.4.1 #537

merged 1 commit into from
Dec 14, 2023

Conversation

gitforwindowshelper[bot]
Copy link

Signed-off-by: Matthias Aßhauer <[email protected]>
@rimrul
Copy link
Member

rimrul commented Dec 14, 2023

/deploy

The workflow run was started.

@rimrul
Copy link
Member

rimrul commented Dec 14, 2023

build-packages CI failure due to results being plural in

echo "results=$artifacts" >>$GITHUB_OUTPUT
and singular in
name: ${{ steps.build.outputs.result }}
path: ${{ steps.build.outputs.result }}

Will fix later.

@rimrul
Copy link
Member

rimrul commented Dec 14, 2023

/add relnote

The workflow run was started

@dscho
Copy link
Member

dscho commented Dec 14, 2023

@rimrul let's merge this, as it has been deployed (and that fact is recorded in the successful builds)?

@rimrul rimrul marked this pull request as ready for review December 14, 2023 13:04
@rimrul rimrul merged commit be94cc6 into main Dec 14, 2023
6 of 7 checks passed
@rimrul rimrul deleted the mingw-w64-git-lfs-3.4.1 branch December 14, 2023 13:04
@rimrul
Copy link
Member

rimrul commented Dec 14, 2023

I was gonna add the CI fix as a commit on top, but that can be it's own PR.

@dscho
Copy link
Member

dscho commented Dec 14, 2023

I was gonna add the CI fix as a commit on top, but that can be it's own PR.

Do you want to do it? I could do it real quick...

@rimrul
Copy link
Member

rimrul commented Dec 14, 2023

Do you want to do it? I could do it real quick...

Go for it. I'll handle git-for-windows/git#4733 in the mean time.

dscho added a commit to dscho/build-extra that referenced this pull request Dec 14, 2023
In git-for-windows#537, the GitHub
workflow failed because the `result` output was inadvertently spelled in
its plural form, which does not work.

Fix that.

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho dscho mentioned this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New git-lfs version] v3.4.1
2 participants