minimal-sdk: accommodate for gettext v0.23.* #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the update of `mingw-w64-gettext-runtime` (0.22.5-2 -> 0.23.1-1), the `ci-artifacts` workflow was failing in `git-sdk-64` (see e.g. https://github.com/git-for-windows/git-sdk-64/actions/runs/12649348500/job/35245565295#step:8:523): MSGFMT po/bg.msg application-specific initialization failed: Can't find a usable init.tcl in the following directories: D:/a/git-sdk-64/git-sdk-64/minimal-sdk/mingw64/lib/tcl8.6 D:/a/git-sdk-64/git-sdk-64/minimal-sdk/mingw64/lib/tcl8.6 D:/a/git-sdk-64/git-sdk-64/minimal-sdk/lib/tcl8.6 D:/a/git-sdk-64/git-sdk-64/minimal-sdk/mingw64/library D:/a/git-sdk-64/git-sdk-64/minimal-sdk/library D:/a/git-sdk-64/git-sdk-64/minimal-sdk/tcl8.6.13/library D:/a/git-sdk-64/git-sdk-64/tcl8.6.13/library This probably means that Tcl wasn't installed properly. The message about Tcl not being installed properly is a red herring: While this _is_ true, the actual fall-back to the real `msgfmt.exe` from the actual `gettext` package _should_ work. As of v0.23, though, that `msgfmt.exe` program now depends on a newly-introduced library, gettext-libtextstyle. So let's include that in minimal SDK's sparse checkout, too. This would have failed in `git-sdk-arm64`, too, if we were running the `ci-artifacts` builds (which we cannot do for financial reasons, seeing as free-of-cost hosted Windows/ARM64 runners for open source are still pushed into the future). What _does_ fail because of this is the `git-artifacts` workflow: https://github.com/git-for-windows/git-for-windows-automation/actions/runs/12689315932/job/35367755275#step:19:1518 So let's fix this also in `git-sdk-arm64`. Cherry-picked-from: e70ecb7 (minimal-sdk: accommodate for gettext v0.23.*, 2025-01-07) Signed-off-by: Johannes Schindelin <[email protected]>
mjcheetham
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of
mingw-w64-gettext-runtime(0.22.5-2 -> 0.23.1-1),msgfmt.exenow depends on a newly-introduced library, gettext-libtextstyle. So let's include that in theminimal-sdksparse checkout, too.This is a companion of git-for-windows#90 and of git-for-windows/git-sdk-32#36