Use the correct action input parameter #1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeisenberg
force-pushed
the
aeisenberg/fix-source-root
branch
from
ceb945c to
415bca9
Compare
|
Looks like we're not allowed to remove the current directory in Actions. |
|
When I get a chance, I'll selectively remove a few key directories to ensure we're not accidentally using them. |
aeisenberg
force-pushed
the
aeisenberg/fix-source-root
branch
6 times, most recently
from
6eb467f to
2819bc4
Compare
aeisenberg
force-pushed
the
aeisenberg/fix-source-root
branch
from
2819bc4 to
da4c460
Compare
|
@angelapwen can you take another look? I think this should work now. |
angelapwen
previously approved these changes
Nov 1, 2023
|
Re-ran and we got an older version of the runner so PR checks have passed 👍 |
aeisenberg
force-pushed
the
aeisenberg/fix-source-root
branch
from
108033a to
8948a7c
Compare
3.12 does not work.
aeisenberg
force-pushed
the
aeisenberg/fix-source-root
branch
from
8948a7c to
bd4005a
Compare
angelapwen
previously approved these changes
Nov 2, 2023
Only run use 3.11 on versions of of the CLI that we know don't support 3.12.
|
Updated to only apply python 3.11 for older CLIs. At some point, we can purge references to CLIs we no longer support, but that can happen at some point in the future. |
henrymercer
previously approved these changes
Nov 2, 2023
henrymercer
approved these changes
Nov 2, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an integration test that isn't quite testing what we think it is.
Also, ensures that all macos tests run on python 3.11. See separate commits.
Merge / deployment checklist