Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the Autobuilder log message referring to build modes clearer #2668

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Make the Autobuilder log message referring to build modes clearer #2668

merged 4 commits into from
Jan 6, 2025

Conversation

sidshank
Copy link
Contributor

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 23, 2024
View reviewed changes
src/autobuild.ts Fixed Show fixed Hide fixed
@sidshank
Copy link
Contributor Author

Closes #2667

@aeisenberg @github-advanced-security
Fix code scanning alert no. 1114: Ensure code is properly formatted, …
ea41240 
…use insertion, deletion, or replacement to obtain desired formatting.

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@aeisenberg aeisenberg added the Rebuild Re-transpile JS & re-generate workflows label Jan 5, 2025
@github-actions github-actions bot removed the Rebuild Re-transpile JS & re-generate workflows label Jan 5, 2025
@aeisenberg
Copy link
Contributor

Transpiling the source code.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2025

Pushed a commit to rebuild the Action. Please mark the PR as ready for review to trigger PR checks.

aeisenberg
aeisenberg reviewed Jan 5, 2025
View reviewed changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense. I'm rebuilding the sources and reformatting using eslint. CI should pass now.

@sidshank sidshank marked this pull request as ready for review January 5, 2025 22:44
@sidshank sidshank requested a review from a team as a code owner January 5, 2025 22:44
henrymercer
henrymercer approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@sidshank sidshank merged commit 3407610 into main Jan 6, 2025
263 checks passed
@sidshank sidshank deleted the sidshank/improve-autobuilder-log-message branch January 6, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeisenberg aeisenberg aeisenberg left review comments

@henrymercer henrymercer henrymercer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sidshank @aeisenberg @henrymercer