Merge pull request #18423 from aschackmull/dataflow/del-deadcode

Dataflow: Remove some dead code.
github · Jan 7, 2025 · 148b78a · 148b78a
2 parents 91f9fb2 + eea85d8
commit 148b78a
Showing 1 changed file with 1 addition and 14 deletions.
diff --git a/shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll b/shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll
@@ -894,12 +894,6 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
       pragma[nomagic]
       predicate revFlow(NodeEx node) { revFlow(node, _) }
 
-      pragma[nomagic]
-      predicate revFlowAp(NodeEx node, Ap ap) {
-        revFlow(node) and
-        exists(ap)
-      }
-
       bindingset[node, state]
       predicate revFlow(NodeEx node, FlowState state, Ap ap) {
         revFlow(node, _) and
@@ -1278,8 +1272,6 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
 
       predicate revFlow(NodeEx node);
 
-      predicate revFlowAp(NodeEx node, Ap ap);
-
       bindingset[node, state]
       predicate revFlow(NodeEx node, FlowState state, Ap ap);
 
@@ -2456,16 +2448,11 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
           )
         }
 
-        additional predicate revFlow(NodeEx node, FlowState state) { revFlow(node, state, _, _, _) }
-
         predicate revFlow(NodeEx node, FlowState state, Ap ap) { revFlow(node, state, _, _, ap) }
 
         pragma[nomagic]
         predicate revFlow(NodeEx node) { revFlow(node, _, _, _, _) }
 
-        pragma[nomagic]
-        predicate revFlowAp(NodeEx node, Ap ap) { revFlow(node, _, _, _, ap) }
-
         private predicate fwdConsCand(Content c, Ap ap) { storeStepFwd(_, ap, c, _, _) }
 
         private predicate revConsCand(Content c, Ap ap) {
@@ -2620,7 +2607,7 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
            */
           private class FlowCheckNode extends NodeEx {
             FlowCheckNode() {
-              revFlow(this, _, _) and
+              revFlow(this) and
               (
                 flowCheckNode(this) or
                 Config::neverSkip(this.asNode())