Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust: fix codegen to allow --force again #17771

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Rust: fix codegen to allow --force again #17771

merged 2 commits into from
Oct 15, 2024

Conversation

redsun82
Copy link
Contributor

This passes command line arguments to codegen, allowing in particular --force to be passed.

Also, a convenience //rust/codegen:py is added to only run the python based code generation, which will be faster and enough when ast-generator is unchanged.

This passes command line arguments to codegen, allowing in particular
`--force` to be passed.

Also, a convenience `//rust/codegen:py` is added to only run the python
based code generation, which will be faster and enough when
`ast-generator` is unchanged.
@github-actions github-actions bot added the Rust Pull requests that update Rust code label Oct 15, 2024
@redsun82 redsun82 changed the title Rust: fix codegen to allow --force Rust: fix codegen to allow --force again Oct 15, 2024
rust/codegen/codegen.sh Outdated Show resolved Hide resolved
paldepind
paldepind previously approved these changes Oct 15, 2024
Copy link
Contributor

@paldepind paldepind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the caveat that, while it seems reasonable, I don't have the knowledge to judge the details of the native_binary configuration.

Co-authored-by: Simon Friis Vindum <[email protected]>
@redsun82
Copy link
Contributor Author

LGTM with the caveat that, while it seems reasonable, I don't have the knowledge to judge the details of the native_binary configuration.

I've more or less reinstated what was there in the first version of this file, under a different name 🙂

Copy link
Contributor

@paldepind paldepind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@redsun82 redsun82 merged commit 886c7f1 into main Oct 15, 2024
13 checks passed
@redsun82 redsun82 deleted the redsun82/rust-codegen branch October 15, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants