Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++: Handle template variable specializations #18367

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Dec 25, 2024

Pull Request checklist

All query authors

Internal query authors only

  • Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to .ql, .qll, or .qhelp files. See the documentation (internal access required).
  • Changes are validated at scale (internal access required).
  • Adding a new query? Consider also adding the query to autofix.

@jketema jketema added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Dec 25, 2024
@jketema jketema force-pushed the jketema/template-parameters-5 branch 3 times, most recently from e32fc08 to f08d100 Compare January 8, 2025 23:49
Base automatically changed from jketema/template-parameters-5 to main January 9, 2025 12:02
@jketema jketema force-pushed the jketema/template-parameters-6 branch from a77b8f6 to 347edc4 Compare January 9, 2025 12:27
@jketema jketema marked this pull request as ready for review January 9, 2025 13:19
@Copilot Copilot bot review requested due to automatic review settings January 9, 2025 13:19
@jketema jketema requested a review from a team as a code owner January 9, 2025 13:19

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 11 changed files in this pull request and generated no comments.

Files not reviewed (6)
  • cpp/downgrades/1a4bbe5ded083b9de87911c155fc99ca22ecb0ce/upgrade.properties: Language not supported
  • cpp/ql/lib/semmle/code/cpp/Function.qll: Language not supported
  • cpp/ql/lib/semmle/code/cpp/Variable.qll: Language not supported
  • cpp/ql/lib/semmlecode.cpp.dbscheme: Language not supported
  • cpp/ql/lib/semmlecode.cpp.dbscheme.stats: Language not supported
  • cpp/ql/lib/upgrades/7eeff19bf7c89a350d3e43516a33c98a270cb057/upgrade.properties: Language not supported

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more

@jketema jketema merged commit 204afab into main Jan 9, 2025
16 checks passed
@jketema jketema deleted the jketema/template-parameters-6 branch January 9, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants