-
Notifications
You must be signed in to change notification settings - Fork 60.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explicit bareRepository configuration when pushing bare mirror #35338
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@jdknight Thanks so much for opening a PR! I'll get this triaged for review ✨ |
Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀 |
@jdknight Thank you for your patience while our SME team reviewed! 💛 Our SMEs reviewed and responded with the following: The problem they're trying to fix sounds real to me, but I think their solution is a bit complicated. The git-config(1) manual page has this to say about safe.bareRepository setting's explicit value:
So, instead of: I think the correct answer would be something more like: Those will both do the same thing in practice, but this version is getting there without needing to override a setting. If you are able to update your PR to match what our SME provided, we will be happy to get this merged ✨ thank you! |
If a user has configured `bareRepository=explicit` in their configuration, the push operation in this example will fail with the message: fatal: cannot use bare repository '<path>.git' (safe.bareRepository is 'explicit') By adding `-c "safe.bareRepository=all"` to the default instruction set, this should prevent issues for users who have bareRepository configured. Signed-off-by: James Knight <[email protected]>
|
This PR has been automatically closed because there has been no response to to our request for more information from the original author. Please reach out if you have the information we requested, or open a new issue to describing your changes. Then we can begin the review process. |
@jdknight Apologies on behalf of our bot! Your latest updates are being reviewed by our SME team, and I'll ping you here as soon as I have a response from them 💛 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested out the steps and this worked for me!
@wiseemily88 Thank you very much for the review! ✨ @jdknight Thank you again for opening this PR! I'll update the branch and get this merged once tests are passing 💛 |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Was following the instructions outlined in Detaching a fork and noticed that step 5 was failing for me.
What's being changed (if available, include any code snippets, screenshots, or gifs):
If a user has configured
bareRepository=explicit
in their configuration, the push operation in this example will fail with the message:By adding
-c "safe.bareRepository=all"
to the default instruction set, this should prevent issues for users who have bareRepository configured.Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.