Upgrade to http 1.0 and hyper 1.1 #4
Conversation
This unavoidably breaks our examples and public API since `Server` was deleted. However, I replaced it with `axum::serve` and found out that `axum::Router` is a decent replacement for our `Router` type and we get to delete a bunch of code.
| @@ -22,7 +22,12 @@ reqwest = { version = "0.11", features = ["default", "gzip", "json"], optional = | |||
| url = { version = "2.5", optional = true } | |||
|
|
|||
| # For the server feature | |||
| hyper = { version = "0.14", features = ["full"], optional = true } | |||
| axum = "0.7" | |||
There was a problem hiding this comment.
Is there a way to do this without taking a dependency on axum? I like axum, but was attempting to have this library be only dependent on hyper...
There was a problem hiding this comment.
It's possible, but I think it's a good idea to return a tower::Service. I think it'll make more people able to use this library, not less, and I think it'll be more convenient for us.
Note that users do not have to buy into axum entirely in order to use this library. Maybe the README should mention this. Because Router is a tower::Service, calling it from some other async server framework that uses http::Request and Response is mainly just my_twirp_router.call(request).await. The tests exercise the router this way.
There was a problem hiding this comment.
Maybe I'm missing the point you're making? If you want, I can revert that and make only docs and examples depend on axum.
There was a problem hiding this comment.
Thanks for opening #7, I can see the challenges a bit better now.
I guess for our purposes, a dependency on axum (and tower) is fine (and really much nicer to use). There's really not a great reason to re-invent our own Body type...
@jorendorff, I trust your judgement here—do you have a sense of which direction is going to be better in the long run here?
|
Axum makes the most sense now. It's a pretty established project for a relative newcomer -- two years old, 14k stars on github, 250 contributors, 100k+ monthly downloads (more than Warp)... Hyper 1.x is designed to be a very low-level back-end library. I think we have to have something on top of Hyper, and Axum is the best existing choice. |
This unavoidably breaks our examples and public API since
Serverwas deleted.However, I replaced it with
axum::serveand found out thataxum::Routeris a decent replacement for ourRoutertype and we get to delete a bunch of code.Bumps both crates' version numbers to 0.2.