Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't panic if Timings are not provided in the Request #9

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

jorendorff
Copy link
Contributor

@jorendorff jorendorff commented Jan 25, 2024

Also adds a test that actually binds the server to the network and tries to talk to it using the client.

This isn't as good as testing the example executables, but it was easy.

Fixes #5.

@jorendorff jorendorff requested a review from a team as a code owner January 25, 2024 21:40
@jorendorff jorendorff requested a review from patrickt January 25, 2024 21:43
Copy link
Contributor

@patrickt patrickt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the solution I landed on, too; I delayed in submitting a PR because I wanted to see if I could use get_mut() instead. I ran up against a wall so I think this is fine for now.

@patrickt patrickt merged commit bf91a2b into main Jan 26, 2024
1 check passed
@patrickt patrickt deleted the jorendorff/fix-timings branch January 26, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example is probably broken
2 participants