Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/587 exercise setups names #606

Merged
merged 4 commits into from
Nov 19, 2022
Merged

Fix/587 exercise setups names #606

merged 4 commits into from
Nov 19, 2022

Conversation

rodrigondec
Copy link
Contributor

@rodrigondec rodrigondec commented Nov 1, 2022 •
edited
Loading

Resume

Some app/project names were not fully updated to the new names!

Some apps are:

  • a1 ecommerce (former a5)

this PR is similar to #598. But there's more mentions to the former A5 name besides those from the Makefile.

@fguisso
Copy link
Member

fguisso commented Nov 1, 2022

Look that this complements PR #598 , we accept this PR but will let it on hold until the other merge.

@fguisso fguisso marked this pull request as ready for review November 1, 2022 02:07
@henriporto henriporto self-assigned this Nov 19, 2022
henriporto
henriporto approved these changes Nov 19, 2022
View reviewed changes
Copy link
Contributor

@henriporto henriporto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job! 👍

@henriporto henriporto merged commit cd48a87 into globocom:master Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henriporto henriporto henriporto approved these changes

Assignees

@henriporto henriporto

Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rodrigondec @fguisso @henriporto