Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add histogram, scatter, and volume viewers to registry #402

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

kecnry
Copy link
Contributor

@kecnry kecnry commented Oct 10, 2023

This PR adds missing viewers (histogram, profile, volume, and image) to the viewer registry.

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0976a06) 86.62% compared to head (bb511ad) 86.65%.
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #402      +/-   ##
==========================================
+ Coverage   86.62%   86.65%   +0.02%     
==========================================
  Files          89       89              
  Lines        5130     5154      +24     
==========================================
+ Hits         4444     4466      +22     
- Misses        686      688       +2     
Files Coverage Δ
glue_jupyter/bqplot/histogram/viewer.py 100.00% <100.00%> (ø)
glue_jupyter/bqplot/image/viewer.py 87.67% <100.00%> (+0.17%) ⬆️
glue_jupyter/bqplot/profile/viewer.py 97.91% <100.00%> (+0.09%) ⬆️
glue_jupyter/ipyvolume/volume/viewer.py 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astrofrog
Copy link
Member

@kecnry - could you also add the image viewer?

@kecnry
Copy link
Contributor Author

kecnry commented Oct 26, 2023

@astrofrog - not sure how I missed that one! Added.

@astrofrog astrofrog merged commit f8e24b8 into glue-viz:main Oct 26, 2023
23 checks passed
@kecnry kecnry deleted the hist-in-registry branch October 26, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants